#5911 closed defect (fixed)
Missing attribution for OSM
| Reported by: | kellerma | Owned by: | mfloryan |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | latest |
| Keywords: | attribution copyright | Cc: |
Description
When displaying a map from the OpenStreetMap the attribution should be displayed properly:
a) the licence (CC-by-SA)
b) the origin (OpenStreetMap)
I know that at the moment there's "OpenStreetMap wechselt die Lizenz. Dazu ist die <etc.>" at the splash screen but that's only a "temporary" "solution".
It would be better to show attribution within the "slippy map chooser". Couldn't find a way
to open a ticket for "jmapviewer" which has the same defect.
Thank you.
Attachments (2)
Change History (24)
comment:1 by , 13 years ago
by , 13 years ago
| Attachment: | [mfloryan]_AttributionHint_for_SlippyMap.patch added |
|---|
Patch with new functionality
comment:2 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 13 years ago
| Summary: | Missing attribution for OSM → Missing attribution for OSM [patch] |
|---|
Indicated this ticket now has a patch.
follow-up: 6 comment:4 by , 13 years ago
Mmmh, maybe I don't understand the patch but why should the attribution text be visible only for 10 s and not as long as the slippy map chooser is active?
When we choose "Bing" within the slippy map chooser the attribution doesn't vanish after 10 seconds.
As a side-note: The "Background Terms of Use" are not "clickable" in the "Bing view".
follow-up: 7 comment:5 by , 13 years ago
The JMapViewer already provides attribution information for all Tile Sources
@anonymous
You're correct, it has been added by Upliner two months ago.
Still if someone likes to add attribution to the "demo-app" JMapViewer_Demo.jar, also.
comment:6 by , 13 years ago
Replying to kellerma:
Mmmh, maybe I don't understand the patch but why should the attribution text be visible only for 10 s and not as long as the slippy map chooser is active?
I added an overlay that shows the attribution text but wasn't sure if it wouldn't be too obtrusive if it stayed fixed.
The patch is for JOSM as I wasn't sure how to submit a patch for JMapViewer but now looking at the code it would be a better place to submit it.
When we choose "Bing" within the slippy map chooser the attribution doesn't vanish after 10 seconds.
True, but that's rendered right on the map. I guess it should equally be rendered on the other maps.
As a side-note: The "Background Terms of Use" are not "clickable" in the "Bing view".
I guess it should be - again, it would need a fix for the JMapViewer. I can prepare one.
comment:7 by , 13 years ago
Replying to kellerma:
The JMapViewer already provides attribution information for all Tile Sources
@anonymous
You're correct, it has been added by Upliner two months ago.
Still if someone likes to add attribution to the "demo-app" JMapViewer_Demo.jar, also.
Yup, this can be done. I'll prepare a cumulative patch for JMapViewer and we can see how to get it applied. If the attribution is shown in the demo it will also be visible in JOSM.
comment:8 by , 13 years ago
Actually I realised that even the current attribution text in the JMapViewer source code for OSM is incorrect. Will fix that too.
by , 13 years ago
| Attachment: | JMapViewer_attribution.patch added |
|---|
Attribution patch for the JMapViewer - will submit to authors.
comment:9 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The patch has been applied and committed as #25314 in the OSM repository.
However, the link is still not click-able, this probably needs to be another piece of work at it might need a more significant change.
comment:10 by , 13 years ago
The patch applied to the SVN broke all TMS layers functionality:
https://josm.openstreetmap.de/ticket/5965
I reverted it partially in OSM rev 25336.
comment:11 by , 13 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
TMS works again but now attribution is also missing again
comment:12 by , 13 years ago
This was a bug in TMS Layer. As soon as #5965 is fixed, the patch can be reapplied.
follow-up: 14 comment:13 by , 13 years ago
It seems that #5965 has been fixed so can you re-apply the "3-lines-only" of the remaining patch?
Thank you.
follow-up: 15 comment:14 by , 13 years ago
comment:15 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:17 by , 13 years ago
| Summary: | Missing attribution for OSM [patch] → Missing attribution for OSM |
|---|
comment:18 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:19 by , 13 years ago
Doesn't work for me, I can see no attribution for Mapnik or other OSM layers.
comment:20 by , 13 years ago
Works for SlippyMapChooser only currently. TMS layers are "hand-made" and thus have no attribution info. I will add this at the Maps page, so future users get the attribution (needs some server work for downwards compatibility before I can make the entries), but I have no idea how to fix this for the legacy entries.
NOTE: Slippymapchooser Mapnik/CycleMap and T@H aren't the same as TMS backgrounds. They get replaced internally for historic reasons.
comment:22 by , 13 years ago
NOTE: Refresh server maps list and probably one or two restarts and you should get attribution also for standard entries.
The JMapViewer already provides attribution information for all Tile Sources. It's just not shown in JOSM.