#5646 closed enhancement (fixed)
[patch] Additional Gas Station Brand Presets
Reported by: | rickmastfan67 | Owned by: | ce |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Internal preset | Version: | latest |
Keywords: | Gas Stations Brands | Cc: |
Description (last modified by )
I was just looking at the presets for the Gas Station Brands inside of JOSM and I noticed a few missing that could be added for the USA (and Canadian) people. Here's a few stations that I recommend adding in the brand presets:
Chevron
Sunoco
Gulf
Exxon
Petro-Canada
Pioneer
Mobil
Citgo
Attachments (1)
Change History (10)
comment:1 by , 14 years ago
Description: | modified (diff) |
---|
by , 14 years ago
Attachment: | gas_station_presets.patch added |
---|
comment:2 by , 14 years ago
Summary: | Additional Gas Station Brand Presets → [patch] Additional Gas Station Brand Presets |
---|
comment:4 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
bastiK, I was just looking @ the change log for when you applied the patch and I noticed something wrong. Somehow, the "A" for "Agip" got deleted when you applied the patch. It was in my patch that I attached. Don't know how that got messed up when you applied it. Must have been a simple typo.
If you look at the change log (3667) you linked to in your post above, you can see the problem. It's the first entry after "values=".
comment:5 by , 14 years ago
Thanks, fixed in [3668]. Did Copy&Paste because patch did not apply for some reason...
comment:6 by , 14 years ago
Replying to bastiK:
Thanks, fixed in [3668]. Did Copy&Paste because patch did not apply for some reason...
Well, as I said in comment #2, this was the first time I've ever done something like this, so I was bound to make some mistake on making the patch. Made it in Notepad++. lol. Guess looking @ somebody's else patch to learn how to do it didn't fully work right. hehe.
comment:7 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:8 by , 14 years ago
Is there a chance additional country-specific brands (even with different char sets) to be included?
I've just created a patch for this. My first attempt at anything like this. So, please let me know if I've done it correctly.