Modify

Opened 14 years ago

Closed 11 years ago

Last modified 11 years ago

#5630 closed defect (fixed)

Zoom shortcuts that don't work on AZERTY keyboard

Reported by: A_Pirard Owned by: team
Priority: normal Milestone: 14.01
Component: Core shortcuts Version: tested
Keywords: zoom keyboard Cc:

Description (last modified by Don-vip)

On Ubuntu 10.04 latest updates :

With AZERTY (on which Period and Plus characters are shifted)

Ctrl+Comma does zoom in but
Ctrl+Period DOES NOT zoom out (neither with or without Shift)

Minus does zoom out, but
Plus DOES NOT zoom out (neither with or without Shift)

The usual practice is to use = or + for zoom in

I know that the definition can be altered bun not everybody does.
Other programs use - and + or = to zoom w/o any configuration.

Conclusion : at least add = for zoom in.
Also Clrl+; for zoom out for added consistency.

Attachments (0)

Change History (15)

comment:1 by Don-vip, 13 years ago

Description: modified (diff)
Resolution: fixed
Status: newclosed

Fixed in r4866.

comment:2 by A_Pirard, 13 years ago

How? No change with 4878.

comment:3 by A_Pirard, 13 years ago

Resolution: fixed
Status: closedreopened

comment:4 by skyper, 13 years ago

Please use at least tested version for tests, as the whole shortcut system has changed lately.

Where do the keys not work ? In main window or in the download dialog ?

comment:5 by anonymous, 13 years ago

Thanks for taking care of this.
What does "at least tested" mean?
Is "main window" View: and "download dialog "Map: the?
What of the keystrokes I mentioned are now supposed to work and how?

I used josm-tested.jar with Belgian AZERTY keyboard on Ubuntu 10.04 on Virtualbox

Because I don't know what to test, I'm guessing.

This was in the config before:

View: Zoom In : Plus
View: Zoom Out : Minus
...
Map: View Zoom In : Ctrl+Comma
Map: View Zoom Out : Ctrl+Period

I don't see Map: anymore.
Should I guess that Plus and Minus are used on both maps?

In this new test, only Minus works and only on the main map.
The other keys do nothing on any map.

So, to summarize simply a complicated issue: if my guesses are right:

Any map: Zoom In : Plus, Equal : both should work and be fixed
Any map: Zoom Out : Minus : should be fixed in the download map.

Oh, BTW, josm-tested.jar is 5047.
Thank you.

PS: this editor shouldn't space lines that I didn't space.

comment:6 by skyper, 11 years ago

Keywords: zoom keyboard added

comment:7 by Don-vip, 11 years ago

Component: CoreCore shortcuts

comment:8 by Don-vip, 11 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in the course of #7802 with r6363 and r6438.

comment:9 by A_Pirard, 11 years ago

Zoom In still does not work -> reopened.

To my abundant literature, the reply is the one-word "fixed", hence, I cannot comment the method used.
But I installed and ran 6449, I investigated and I see that the following shortcut entry was added:
View Zoom In <- Shift+Equals
Again, I don't know if you access the keyboard physically or system translated, but I doubt that my line

The usual practice is to use = or + for zoom in

should result in specifying the shift key (AZERTY = is unshifted and + is shifted =).

All that I can say for sure is that I reconfigured instead
View Zoom In <- Equals
and that pressing Equals does now Zoom In (and Minus does Zoom Out).

AZERTY users have all they need if they don't try to use Plus.
Plus does nothing, but please DO NOT TRY: it's useless on AZERTY.

Thanks for our mutual patience.

comment:10 by A_Pirard, 11 years ago

Resolution: fixed
Status: closedreopened

in reply to:  9 comment:11 by Don-vip, 11 years ago

I'm using an AZERTY keyboard too and it works for me with shift =, as the + character is above the = character. Or do Belgian keyboards differ so much than French ones ?

I have just tested again, it works fine with a French keyboard on Windows. I do not have access to Ubuntu right now to see if this is Linux-specific.

comment:12 by A_Pirard, 11 years ago

In 1992, I wrote in ftp://ftp.ulg.ac.be/pub/docs/iso8859/iso8859.networking.txt (the foreign environment) that the state of the shift key or like shouldn't be tested (nor the position of the key) when inputting characters. That's because these states may differ on different keyboards.

In this bug I wrote:
The usual practice is to use = or + for zoom in (on the same QW or AZ key;+ is shifted =)
Conclusion : at least add = for zoom in.
(- and = are convenient for zooms because they are unshifted)

If, with Ubuntu 12.04 and 6449, I look at the default configuration, I see
View: Zoom In Plus
View: Zoom In Equals + Shift

Neither works.
In a first time, I don't care much about Plus, because nobody would use Equals.

And hence, I wondered why the second config tests Shift when Equals is not using it (and it shouldn't test shift at all). So I removed that + Shift, and ... it works.

I'm not sure why you want to use Plus but I'm helpful and curious on top.
I set the first config to Plus + Shift just in case and it does NOT work.

Yes the Belgian +/= key is the same, but it's near the right shift key.

So, I absolutely don't grasp what happens.
But I'm absolutely certain since 1992 that it should not happen.
JOSM receives characters =, +, - and the rest perfectly all right (as I type them here).
It should have no problem if the shift key, key position and the rest are left alone.
But it does not leave them alone.

I let you decide what you will do.
But if that Equals works without + Shift for everybody let's do that.

Why do I always write 10 lines for 1 I reply to.
And that's to spare OSM users the time searching why their keyboard doesn't work.
I, myself, know, of course !!!

comment:13 by Don-vip, 11 years ago

Milestone: 14.01

comment:14 by Don-vip, 11 years ago

Resolution: fixed
Status: reopenedclosed

In 6710/josm:

fix #5630 - use Equals as another shortcut to zoom in

comment:15 by anonymous, 11 years ago

Yep, Equals now zooms in by default !!!
Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.