[Patch] Empty OSM files not announced

[jp42@…]

Was trying to clean up a few lone tags. Loading this link returns an empty osm document - tags have already been fixed by someone else.

​http://tagwatch.stoecker.eu/osmxapi/*[bikeway=lane]

The node/way/relation panels are empty but they may not be on show to the user. The map just shows a strip of the whole world above about latitude 67 degrees. The rest of the map is missing/white. The user may think there is some data and it's not showing on the map. Especially as nodes show as yellow against a white background.

It would save time if JOSM announced the document is empty as soon as it is loaded. It will do this if you try and save an empty document.

It all gets more confusing when you find that tags listed here for Australia-Oceania contain tags in Europe - making any clean up much more difficult:

​http://tagwatch.stoecker.eu/Australia-oceania/En/tags.html

see tag: bicycle=y The node is very hard to spot:

​http://tagwatch.stoecker.eu/osmxapi/*[bicycle=y]

see tag: access=bicycle Shows nodes in Europe

​http://tagwatch.stoecker.eu/osmxapi/*[access=bicycle]

In the majority of cases, ways/relations are highly localised (compared to the planet). Can JOSM zoom to the extent of the way(s)/relation(s)? That way you don't have to search on the map for them.

[simon04]

test file

[simon04]

Could be fixed with the attached patch – I'm not very sure where to put include this information dialog.

[bastiK]

Guess it is ok, but for stuff like this it would be great to have balloon notifications. I.e. tooltips that pop up on the map, but don't interrupt the work flow.

[simon04]

Is it all right to commit this change now? When a balloon notification is implemented, this can be changed.

[bastiK]

Sure, just avoid adding new bugs. (This patch looks pretty save...)

[simon04]

In [4393/josm]:

fix #5471 - information dialog when opening an empty osm file