Modify ↓

Opened 17 years ago

Closed 11 years ago

#518 closed defect (fixed)

[PATCH] Unicode normalization

Reported by: moyogo@… Owned by: framm
Priority: minor Milestone: 14.01
Component: Core Version: latest
Keywords: Cc:

Description (last modified by Don-vip)

JOSM should normalize strings at input. They should also be normalized when searching.

For example inputing name="Rue de l'École" should end up the same as name="Rue de l'École". The first has "É" as U+0045 LATIN CAPITAL LETTER E + U+0301 COMBINING ACUTE ACCENT while the second has "É" U+00C9 LATIN CAPITAL LETTER E WITH ACUTE.
Searching for one should match the other.

See ​http://unicode.org/faq/normalization.html for more info.

java.text.Normalizer.normalize(string, java.text.Normalizer.Form.NFC) can be used when required.
NFC is probably better because it's better supported than NFD due to legacy.

Attachments (1)

josm-normalization.patch​ (2.1 KB ) - added by moyogo@… 17 years ago.
normalizing strings before comparison in SearchCompiler, and value in PropertiesDialog

Download all attachments as: .zip

Change History (5)

by moyogo@…, 17 years ago

Attachment: josm-normalization.patch​ added

normalizing strings before comparison in SearchCompiler, and value in PropertiesDialog

comment:1 by stoecker, 16 years ago

Summary: Unicode normalizatin → [PATCH] Unicode normalization

comment:2 by stoecker, 16 years ago

Resolution: → fixed
Status: new → closed

Fixed in r1155.

comment:3 by Don-vip, 11 years ago

Description: modified (diff)
Milestone: → 14.01
Priority: trivial → minor
Resolution: fixed
Status: closed → reopened

Normalization has been reverted in r1168 but only partially restored in r3556.

Entering name="Rue de l'École" or name="Rue de l'École" do not produce the same result, even if both are found thanks to search compiler.

comment:4 by Don-vip, 11 years ago

Resolution: → fixed
Status: reopened → closed

In 6700/josm:

fix #518 - Unicode normalization in add/edit tags dialog

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.