Modify

Opened 15 years ago

Closed 15 years ago

#4440 closed defect (worksforme)

Please give merged file a new layer/file name

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: merge save Cc: skyper

Description

Salut

Please give the layer after merging to osm files a new layer/file name. Right now the name is the same you merged to. If you load the origanal file, you can not distinguish between them (same name) and you can exidently overwrite it, too.

Thanks skyper

Attachments (0)

Change History (6)

comment:1 by mjulius, 15 years ago

I don't think it is a good idea to make it standard behavior to change the layer name every time some data is merged into it. The best option you have now is to do Save As. You can also create a new layer and then merge both of your layers into that one.

The layer context menu already offers to rename the layer. The Rename layer dialog should probably get a checkbox that, when checked, causes the layer to forget its file association.

Another possibility might be to implement a new "Merge into new layer" action that merges all selected layers into a new one and thus combining the steps mentioned above into one command.

in reply to:  1 comment:2 by skyper, 15 years ago

Replying to mjulius:

I don't think it is a good idea to make it standard behavior to change the layer name every time some data is merged into it. The best option you have now is to do Save As. You can also create a new layer and then merge both of your layers into that one.

The layer context menu already offers to rename the layer. The Rename layer dialog should probably get a checkbox that, when checked, causes the layer to forget its file association.

Another possibility might be to implement a new "Merge into new layer" action that merges all selected layers into a new one and thus combining the steps mentioned above into one command.

Sounds all good for me. My biggest concern is that if you save after a layer-merge, you can accidently overwrite a file by just saving it. I do not care how this is prohibite but right now you are not warned at all. Maybe a warning that you are overwriting the file would do it.

comment:3 by anonymous, 15 years ago

Why is the merge operation so different to you from any other edit you do to a layer? Do you want a warning like "The data has changed. Saving it will change the file on disk. Do you really want to continue?"

in reply to:  3 comment:4 by skyper, 15 years ago

Replying to anonymous:

Why is the merge operation so different to you from any other edit you do to a layer?

I can not undo a merge and right now there are quite a lot of bugs with merges. It happend to me yesterday, that I overwrote a file, luckily I had the original still open and I knew which one of the two files with the same name the original one was. So I could save the original one again.

comment:5 by mjulius, 15 years ago

(In [2901]) new button in LayerListDialog: Duplicate Layer
This creates a duplicate of the selected layer without a file association
see #4440

in reply to:  5 comment:6 by skyper, 15 years ago

Resolution: worksforme
Status: newclosed

Replying to mjulius:

(In [2901]) new button in LayerListDialog: Duplicate Layer
This creates a duplicate of the selected layer without a file association
see #4440

That will work for me and I do not have to load the original one again, too.

Nice solution.
Thanks

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.