[Patch] Downloading incomplete relation members no longer downloads correct data

[stoecker]

The download of incomplete relation members now only downloads the members itself. This is pretty much useless and also introduces incomplete ways, which we never had.

When downloading data, only relations should contain incomplete elements, nothing else.

[mjulius]

This is caused because the object reader was checking for Way.isIncomplete() instead of Way.hasIncompleteNodes()

See the attached patch.

I also moved the code from setHasIncompleteNodes() to hasIncompleteNodes() because it is almost guaranteed that someone will forget to call setHasIncompleteNodes() when some node changes its status.

[mjulius]

Ticket #4143 has been marked as a duplicate of this ticket.

[stoecker]

(In [2609]) applied #4146 - patch by mjulius - fix downloading incomplete relation

[stoecker]

I'm not so sure, that inlining the hasIncompleteNodes() is really perfect (as isincomplete() is really called very often, but probably it is better than previous solution.

After we fixed the remaining design issues we need to do some profiling to get back some of the speed lost during last changes.

[mjulius]

Yes, I know that this has probably an impact on performance. But, relying on setHasIncompleteNodes() to be called every time is not very reliable.

Maybe this should be moved to OsmPrimitive. This could get a flag "hasIncompleteMembers" and a method checkForIncompleteMembers(). OsmPrimitive.setIncomplete() could then call this when the incomplete status changes. It would also need to be called when members are added or removed.