Cognitive load increases with the new upload dialog

[avarab@…]

I'm finding that I spent a longer time staring at the upload dialog introduced in [2599] than I did previously after using it for a while.

The reason for this is that before [2599] the information in the "Changesets" tab was visible on the main upload screen and since it was presented as radio buttons / checkboxes & a drop-down list it was easy to glance at it to see whether something changed.

However after [2599] it has been replaced by two paragraphs of text and I find myself reading them over every time I look at them. Having either new changeset or open changeset in the middle of a paragraph along with either left open or closed isn't as easy to spot at a glance as just looking at radio buttons.

However as noted in #4129 having it all in one dialog takes up too much space. So how about this as a design which should please all parties:

• Get rid of the tab-bar in the changeset dialog (Settings, Changeset tags, Changesets, Advanced)
• Hide the Changeset tags, Changesets, Advanced settings behind a expanding/collapsing UI element similar to what's used for the right-sidebar in JOSM.

This would make the entire upload dialog look like this:

Provide a brief comment for the changes you are uploading:
[Trace some stuff from Yahoo!]
[>] Uploading '''3 objects''' to '''1 changeset''' using '''1 request'''
[>] Objects are uploaded to a '''new changeset'''. The changeset is going to be '''closed''' after this upload.
[>] There are '''no custom''' changeset tags in this changeset

    [ Upload Changes ] [ Cancel ] [ Help ]

The user could then click on the [>] buttons to expand them, e.g. if the [>] button beside the changeset button were to be clicked the dialog would look like this:

Provide a brief comment for the changes you are uploading:
[Trace some stuff from Yahoo!]
[>] Uploading '''3 objects''' to '''1 changeset''' using '''1 request'''
[*] Please decide what changeset data is uploaded to and whether to close the changeset after the next upload
  [X] Upload to a new changeset
  [ ] Upload to an existing changeset [ No open changesets ] [Refresh] [Close]
 [X] Close changeset after upload
[>] There are '''no custom''' changeset tags in this changeset

    [ Upload Changes ] [ Cancel ] [ Help ]

Whether individual UI elements were expanded or not would be saved to the preferences (just as with the right sidebar now) so if someone always wanted to see the full dialog they could just expand all the elements & have JOSM remember that setting.

[Don-vip]

Ticket #9269 has been marked as a duplicate of this ticket.

[gaben]

Fixed in r17709, see #20708 for comments.