Upload does upload unchanged nodes/ways/relations

[andre68@…]

JOSM currently uploads nodes/ways/relations even if they have not been changed or the change was retracted by not using undo.

Example 1: Adding a tag to a node und removing that tag afterwards without using undo. Undo is not usable if there were other changes in the meantime. The node is beeing uploaded then which should not be the case.

Example 2: Joining ways. When a node of way1 is joined to way2 then both way1 and way2 are beeing uploaded even though way1 was not modified.

This unnecessarily stresses the OSM server and makes the history of the object unnecessarily long.

JOSM should compare the current attributes of an object with the old state and should only upload the object when there was a real change.

[Daeron]

Attached patch fixes the second case.

The first case would need either storing the original version of all modified objects and on upload comparing for actual changes, or storing a hash for the original version, and comparing that to the modified versions hash.

[stoecker]

(In [2431]) applied #3804 - patch by Daeron - reduce unnecessary changes

[anonymous]

The patch was only for the example 2, the example 1 needs further improvements

[skyper]

Still in r4013

[stoecker]

Well, case 1 is not that simple. We would need to have a "remember current server state" and then check if modified element is really different to the server version. I'm pretty sure there is another older ticket which has the same idea as improvement.

[Don-vip]

Closed as duplicate of #3384.