#3696 closed enhancement (fixed)
[PATCH] Replace OsmPrimitive selection implementation with storage in DataSet
Reported by: | hansendc | Owned by: | hansendc |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Cc: | Gubaer, hansendc |
Description
There will be three patches attached here:
- implement a LinkedHashSet inside DataSet to track selected objects
- Remove the OsmPrimitive selection functions
- Use the new LinkedHashSet to optimize a few operation in the DataSet
The LinkedHashSet should preserve ordering. The first item selected should be the first item returned from all of the functions that query selections. If an item is reselected, such as if a user clicked on it, then drew a box around it with Ctrl, the order of the first selection is maintained. This is due to the LinkedHashSet implementation.
Attachments (7)
Change History (14)
by , 15 years ago
Attachment: | implement-selection-storage-in-DataSet.patch added |
---|
by , 15 years ago
Attachment: | remove-primitive-selection-implementation.patch added |
---|
by , 15 years ago
Attachment: | optimize-selection-code.patch added |
---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
Summary: | Replace OsmPrimitive selection implementation with storage in DataSet → [PATCH] Replace OsmPrimitive selection implementation with storage in DataSet |
---|
comment:3 by , 15 years ago
Cc: | added |
---|
Here are 3 updated patches. They've been updated to the latest svn
by , 15 years ago
Attachment: | implement-selection-storage-in-DataSet.2.patch added |
---|
by , 15 years ago
Attachment: | remove-primitive-selection-implementation.2.patch added |
---|
by , 15 years ago
Attachment: | optimize-selection-code.2.patch added |
---|
comment:4 by , 15 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
Again, build is broken after the patches are applied (addSelected() on DataSet is missing)
comment:5 by , 15 years ago
Status: | needinfo → assigned |
---|
Ugh. Too many patches in too many tickets. ant is also really bad at finding .class files that are out of date.
by , 15 years ago
Attachment: | add-ds-addSelected.patch added |
---|
comment:6 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:7 by , 15 years ago
Please, please don't make multi-file patches. It's a pain to apply them.
I can't apply the patches. Two problems identified so far:
selectedPrimitves
inDataSet
missing?