Confusing conflict message

[bilbo]

I tried to upload data to dataset I thought was open (I found later that it was automatically closed due to inactivity) and I was present with "Conflict detected" dialog, telling me server have newer version of the stuff I am trying to upload. This is very confusing.

In console I see:

WARNING: Warning: error header "The changeset 2475838 was closed at Sun Sep 13 23:26:17 UTC 2009" did not match expected pattern "Version mismatch: Provided (\d+), server had: (\d+) of (\S+) (\d+)"

I guess the case of changeset getting somehow closed behind JOSM's back should be detected and more appropriate dialog presented to the user instead (like "Changeset is already closed, do you wish to open new one?")

[Bürste]

I think very confusing for new users, changing priority.

[Gubaer]

(In [2134]) fixed #3489: Confusing conflict message

[bilbo]

Seems to be still broken:

PUT ​http://www.openstreetmap.org/api/0.6/changeset/2500779... Conflict
Error header: The changeset 2500779 was closed at Wed Sep 16 18:56:20 UTC 2009
Sep 16, 2009 9:49:36 PM org.openstreetmap.josm.actions.UploadAction handleUploadConflict
WARNING: Warning: error header "The changeset 2500779 was closed at Wed Sep 16 18:56:20 UTC 2009" did not match expected pattern "The changeset (\d+) was closed at (.*)"

And in the source ... err.... if you change the pattern you have to compile it too :)

See attached patch for fix

[bilbo]

fix

[Gubaer]

(In [2153]) applied #3489: patch by singularita@…: Confusing conflict message