Validator - fixing duplicate nodes spams with many dialogs

[bilbo]

When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:

When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).

This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")

[anonymous]

OSM file with bad data that I tried to fix using Validator

[anonymous]

Replying to anonymous:

When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:

When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).

This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")

In 2561 (current tested) you can disable this dialogue:
settings (F12)
advanced settings (last entry in list)
message.delete_outside_nodes= (empty)
message.delete_outside_nodes.value=1

These settings do not delete the outside_nodes as the value "1" implies!

[HamishB <hamish_b@…>]

for me using the latest testing release (r3208) I still see the errors listed in the validator results box, but when I hit fix it just fixes the downloaded ones it is sure about. no annoying dialog boxes. haven't touched the advanced properties.

so is this one fixed?

Hamish

[HamishB <hamish_b@…>]

(it might be nice to get a "x errors not fixed as components are partially out of region" or so message, at fist I couldn't figure out why "Fix" didn't fix them. until I zoomed to one and guessed why)

[GerdP]

I think this was partly fixed with r10924, see also #13494.

[Don-vip]

In 11627/josm:

fix #3346 - improve drastically the performance of fixing duplicate nodes by:

• caching data sources area computation
• moving layer invalidation from UndoRedoHandler.addNoRedraw to UndoRedoHandler.add
• avoiding any EDT call when building tag conflict dialog if it's not meant to be displayed

[Don-vip]

In 11628/josm:

see #3346 - remove debug info committed accidentally

[Don-vip]

In 11629/josm:

see #3346 - findbugs - IS2_INCONSISTENT_SYNC

[Don-vip]

In 11630/josm:

see #3346 - update unit test

[GerdP]

Replying to Don-vip:

In 11627/josm:

fix #3346 - improve drastically the performance of fixing duplicate nodes by:

• caching data sources area computation
• moving layer invalidation from UndoRedoHandler.addNoRedraw to UndoRedoHandler.add
• avoiding any EDT call when building tag conflict dialog if it's not meant to be displayed

I wonder if this works when e.g. a plugin modifies the public field Dataset.dataSources. Do you plan to change that to
private?

[Don-vip]

After updating the plugins, yes. At least PBF and O5M plugins are concerned.

[Don-vip]

In 11632/josm:

see #3346 - make DataSet.dataSources private