[PATCH] updated Plugins are downloaded twice

[malenki]

Since some time Josm shows this behaviour:
When I update the plugins, I am asked if I want to download the latest versions of the plugins. I answer with yes, the plugins are downloaded, then I close Josm - and am asked again, if I want do download the latest versions of the plugins. Of course I say yes, the plugins are downloaded again and Josm closes.

After restarting Josm all updated plugins aren't loaded anymore. So I have to go to the settings, check all boxes of the plugins I need (and don't forget any), close settings, close Josm and start Josm again.

Unnerving.

I'd appreciate a lot this being fixed

[stoecker]

Which Version of JOSM do you run?
Which OS do you use?

[malenki]

Josm 1729 (sorry for not telling), seen this behaviour at least a month since.

2.6.30-1.slh.1-sidux-686 (debian unstable)

java version "1.6.0_14"
Java(TM) SE Runtime Environment (build 1.6.0_14-b08)
Java HotSpot(TM) Server VM (build 14.0-b16, mixed mode

[Cobra]

I can confirm this just happened with my version, too.

JOSM 1729, Linux (Ubuntu 8.04LTS, Java6).
How to reproduce:

• open settings, update plugins, confirm, plugins are downloaded the first time
  
• close settings and josm asks you whether you want to download the (same) plugins (once again), confirm, plugins are downloaded for the second time
  
• close josm
  
• start josm again and notice that many plugins are disabled
  
• re-enable them, restart josm and everything works again
  

[stoecker]

Hmpf, I lately added code to prevent such behaviour and now it is back again.

[anonymous]

plugin is added to failed list when it's downloaded sucessfully. See patch

[jttt]

I didn't test updating, but downloading new plugins didn't work either and thats now fixed.

[stoecker]

Should be fixed in r1732. When plugins are added to the "failed"-list in case the download was ok such things happen.

Please reopen report if there are still problems.

Hui, your patch comes too late. :-)

[Cobra]

I have to reopen this ticket, since josm still downloads the plugins twice...
But at least they are loaded after restarting josm.

Still the same behaviour as mentioned by me above:

• open settings, update plugins, confirm, plugins are downloaded the first time
  
• close settings and josm asks you whether you want to download the (same) plugins (once again), confirm, plugins are downloaded for the second time

[stoecker]

What OS? Windows?

[Cobra]

same setup as above (JOSM 1732, Linux (Ubuntu 8.04LTS, Java6))

[stoecker]

Hmm, then somehow the list update fails.

JOSM should now take downloaded files into account as well when checking versions. Somehow here must be a mismatch. I will add some more verbose output about download (e.g. adding versions) to help debugging that issue (But now my motorbike is calling :-).

[jttt]

There are two issues:

• plugin list is not updated
• new version of plugin is downloaded after user press OK even when the plugin was installed before and user doesn't want to update it

I will provide a patch, this time I make sure you won't be faster :-)

[stoecker]

Best would be when the download request would ask (using checkboxes) what to do:

• Update xxx from ... to ...
• Download xxx in version ...

Also the "JOSM is to old - really download" warning could somehow be included in this dialog.

[jttt]

Should list of plugins to update be shown also in download dialog? For example:

Download plugin ...
Download plugin ...
Update plugin ... from to ...

The usuall usecase then will be:

• Download list
• if there are plugins that can be updated then show message somewhere
• When OK is pressed download and update plugins

Update button then will not be neccessary though it should probably stay.

The "JOSM is old" message could be written bellow affected plugin and checkbox for that plugin should be disabled by default.

Btw. I've also noticed another issue - once plugin is provided without version information then it will never get updated again.

[jttt]

I've added a patch that fix this issue. I was wrong about not updating plugins without version though the check was really complicated and I'm still not sure what it meant. I've changed it to simply to update if version is different, don't care about empty versions (except null pointer check).

[stoecker]

In r1738.

Well, the plugin handling is to change a lot still.

Also currently josm does not care about different locally installed versions (which different write permissions), which makes packaging complicated. If you have time any improvements are welcome.