Change what "interesting direction hints" means

[augustus.kling@…]

The behavior of Preferences→Display Settings→OSM Data→Draw Direction Arrows→Only interesting direction hints is not optimal and sometimes confusing.

Arrows should not be shown for ways tagged as oneway=no as stated in #2387. Are the mentioned speed reasons longer valid for the current code base? If I understood the code correctly the checkDirectionTagged method of OsmPrimitive class is only called at changes of tags. Thus it should not matter a lot to also check a tag's value if the tag name was contained within directionKeys.

The direction hint arrows should also be displayed for waterways tagged as stream, river, canal and drain. This needs to be discussed here as the direction matters but does not automatically restrict the moving direction of boats (for example).

Additionally piste:type tags for the values downhill and sled as well as man_made=piste:halfpipe should receive direction hints.

[jttt]

I've tested using search pattern (as in Edit - Search action) instead of key list. The performance impact was negligible. I don't want to commit that now, because new JOSM tested is about to be released and I've also rewritten SearchAction a bit (so it's quite possible I broke something).

After new code is commited, it will be possible to use arbitrary condition when deciding whether arrows should be shown.

[jttt]

(In [2883]) Fixed #2809 Change what "interesting direction hints" means

[bastiK]

Ticket #3973 has been marked as a duplicate of this ticket.

[bastiK]

Ticket #3273 has been marked as a duplicate of this ticket.