Relation editor is broken

[Teemu Koskinen <teemu.koskinen@…>]

[1596] broke opening the relation editor, when trying to open a relation that have members which aren't downloaded yet.

java.lang.ArrayIndexOutOfBoundsException: -1
        at java.util.ArrayList.get(ArrayList.java:324)
        at org.openstreetmap.josm.data.osm.Way.lastNode(Way.java:176)
        at org.openstreetmap.josm.gui.dialogs.RelationEditor.refreshTables(RelationEditor.java:386)
        at org.openstreetmap.josm.gui.dialogs.RelationEditor.setupBasicLayout(RelationEditor.java:245)
        at org.openstreetmap.josm.gui.dialogs.RelationEditor.<init>(RelationEditor.java:152)
        at org.openstreetmap.josm.gui.dialogs.RelationEditor.<init>(RelationEditor.java:117)
        at org.openstreetmap.josm.gui.dialogs.RelationListDialog$1.actionPerformed(RelationListDialog.java:63)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
        at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
        at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
        at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
        at java.awt.Component.processMouseEvent(Component.java:6216)
        at javax.swing.JComponent.processMouseEvent(JComponent.java:3265)
        at java.awt.Component.processEvent(Component.java:5981)
        at java.awt.Container.processEvent(Container.java:2041)
        at java.awt.Component.dispatchEventImpl(Component.java:4583)
        at java.awt.Container.dispatchEventImpl(Container.java:2099)
        at java.awt.Component.dispatchEvent(Component.java:4413)
        at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4556)
        at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4220)
        at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4150)
        at java.awt.Container.dispatchEventImpl(Container.java:2085)
        at java.awt.Window.dispatchEventImpl(Window.java:2475)
        at java.awt.Component.dispatchEvent(Component.java:4413)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[stoecker]

Ticket #2600 has been marked as a duplicate of this ticket.

[mikh43]

My similar - but not identical ticket 2600 was closed as a 'duplicate'. Nevertheless, it might be worth noting that in my case the relations concerned, so far as I can see, did NOT have any members that were not downloaded yet. I am commenting here, rather than reopening my own ticket, but it does appear that the problem(s) with the relation editor are more general than this ticket would imply. I cannot find any relation that I can edit with v 1596. Hope this is helpful.

[Teemu Koskinen <teemu.koskinen@…>]

Replying to mikh43:

My similar - but not identical ticket 2600 was closed as a 'duplicate'. Nevertheless, it might be worth noting that in my case the relations concerned, so far as I can see, did NOT have any members that were not downloaded yet. I am commenting here, rather than reopening my own ticket, but it does appear that the problem(s) with the relation editor are more general than this ticket would imply. I cannot find any relation that I can edit with v 1596. Hope this is helpful.

In my case, the relation editor opens and works fine once all the members have been downloaded. It's just not practical when dealing with big route relations, as they might cover a great area.

[framm]

Fixed in r1598. This bug was introduced when I added the linkage check for relation members.

[anonymous]

Ticket #2605 has been marked as a duplicate of this ticket.

[anonymous]

Ticket #2606 has been marked as a duplicate of this ticket.