#24093 closed defect (fixed)
Wrong page is linked for context sensitive help for Edit -> Delete action
Reported by: | skyper | Owned by: | taylor.smock |
---|---|---|---|
Priority: | minor | Milestone: | 25.01 |
Component: | Core | Version: | latest |
Keywords: | template_report context sensitive help delete | Cc: |
Description
What steps will reproduce the problem?
- Have an new empty data layer
- Click on Edit menu and move the mouse pointer over "Delete"
- Press
F1
What is the expected result?
The page wiki:Help/Action/EditDelete is opened in the help browser
What happens instead?
The page wiki:Help/Action/Delete is opened as the wrong page is set at source:/trunk/src/org/openstreetmap/josm/actions/DeleteAction.java#L78
Please provide any additional information below. Attach a screenshot if possible.
Looking at wiki:DevelopersGuide/HelpSystem/HelpTopicsList both the mode and the action have the identical name "Delete".
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2025-01-17 11:48:11 +0100 (Fri, 17 Jan 2025) Revision:19286 Build-Date:2025-01-18 02:30:38 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (0)
Change History (6)
comment:1 by , 4 weeks ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 4 weeks ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:3 by , 4 weeks ago
Thanks, I always wonder if a patch is more appreciated for those small changes or if I better spend my time for writing the ticket's description with more details.
comment:4 by , 4 weeks ago
If you like expressive things, they may help newcomers in this way. If you don't have time and a patch is self-explanatory, then a patch, I would say :)
comment:5 by , 4 weeks ago
Patch or description is up to you. I (personally) don't care either way.
From a long-term perspective, having some things marked as good first contributor tickets would be a good thing. The thing we have to consider is that those easy fixes tend take <10m to fix for someone familiar with the codebase, so it is hard to justify leaving the ticket open for an extended period of time.
In 19290/josm: