Modify

Opened 4 weeks ago

Closed 4 weeks ago

Last modified 4 weeks ago

#24093 closed defect (fixed)

Wrong page is linked for context sensitive help for Edit -> Delete action

Reported by: skyper Owned by: taylor.smock
Priority: minor Milestone: 25.01
Component: Core Version: latest
Keywords: template_report context sensitive help delete Cc:

Description

What steps will reproduce the problem?

  1. Have an new empty data layer
  2. Click on Edit menu and move the mouse pointer over "Delete"
  3. Press F1

What is the expected result?

The page wiki:Help/Action/EditDelete is opened in the help browser

What happens instead?

The page wiki:Help/Action/Delete is opened as the wrong page is set at source:/trunk/src/org/openstreetmap/josm/actions/DeleteAction.java#L78

Please provide any additional information below. Attach a screenshot if possible.

Looking at wiki:DevelopersGuide/HelpSystem/HelpTopicsList both the mode and the action have the identical name "Delete".

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2025-01-17 11:48:11 +0100 (Fri, 17 Jan 2025)
Revision:19286
Build-Date:2025-01-18 02:30:38
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (6)

comment:1 by taylor.smock, 4 weeks ago

Owner: changed from team to taylor.smock
Status: newassigned

comment:2 by taylor.smock, 4 weeks ago

Resolution: fixed
Status: assignedclosed

In 19290/josm:

Fix #24093: Wrong page is linked for context sensitive help for Edit -> Delete action

comment:3 by skyper, 4 weeks ago

Thanks, I always wonder if a patch is more appreciated for those small changes or if I better spend my time for writing the ticket's description with more details.

comment:4 by gaben, 4 weeks ago

If you like expressive things, they may help newcomers in this way. If you don't have time and a patch is self-explanatory, then a patch, I would say :)

comment:5 by taylor.smock, 4 weeks ago

Patch or description is up to you. I (personally) don't care either way.

From a long-term perspective, having some things marked as good first contributor tickets would be a good thing. The thing we have to consider is that those easy fixes tend take <10m to fix for someone familiar with the codebase, so it is hard to justify leaving the ticket open for an extended period of time.

comment:6 by stoecker, 4 weeks ago

Add a keyword and a search for it ;-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain taylor.smock.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.