Modify

Opened 7 weeks ago

Last modified 7 weeks ago

#23945 new enhancement

[PATCH] ImageViewerDialog.displayImages() - do not re-center if the image has not changed

Reported by: IreuN Owned by: team
Priority: normal Milestone:
Component: Core image mapping Version:
Keywords: Cc:

Description (last modified by gaben)

Hello!

I'm asking you if mention method could be changed to not zoom map to the image, in case the image is the same one.
This could be benefitial to Mapillary plugin, which has to re-display the image after sequence has been downloaded (without it, the previous/next buttons are disabled.

as i can see there is already imageChanged = currentEntry != entry; which could be fed to the if statement.

            imageChanged = currentEntry != entry;

            if (centerView && entry != null && MainApplication.isDisplayingMapView() && entry.getPos() != null) {
                MainApplication.getMap().mapView.zoomTo(entry.getPos());
            }

josm/trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java#L893

Attachments (1)

78e599ef8d48e96abbec01c697e6987f8dc4d7e5.patch (1.1 KB ) - added by IreuN 7 weeks ago.

Download all attachments as: .zip

Change History (5)

comment:1 by IreuN, 7 weeks ago

Video of what this causes: https://streamable.com/osypzs

comment:3 by IreuN, 7 weeks ago

Summary: ImageViewerDialog.displayImages() - do not re-center if the image has not changed[PATCH] ImageViewerDialog.displayImages() - do not re-center if the image has not changed

comment:4 by gaben, 7 weeks ago

Component: CoreCore image mapping
Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to IreuN.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.