Modify

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#23859 closed defect (invalid)

"Join Node to Way" and "Move Node onto Way" are not working

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: template_report node way join move Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. Have an isolated node (id:12078053542) and a way near the node, see josm_23859_example.osm
  2. Select the node
  3. "Join Node to Way" J or "Move Node onto Way" N

What is the expected result?

The way includes the node

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

I only use these actions occasionally so I do not know when these actions stopped working

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-08-12 21:35:07 +0200 (Mon, 12 Aug 2024)
Revision:19192
Build-Date:2024-08-13 01:30:39
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19192 en) Linux Debian GNU/Linux 12 (bookworm)
Memory Usage: 369 MB / 1970 MB (130 MB allocated, but free)
Java version: 17.0.12+7-Debian-2deb12u1, Debian, OpenJDK 64-Bit Server VM

Attachments (1)

josm_23859_example.osm (2.5 KB ) - added by skyper 2 months ago.
example file

Download all attachments as: .zip

Change History (10)

by skyper, 2 months ago

Attachment: josm_23859_example.osm added

example file

comment:1 by skyper, 2 months ago

Description: modified (diff)

comment:2 by skyper, 2 months ago

Description: modified (diff)

comment:3 by GerdP, 2 months ago

You probably have to zoom out. Even if the way and the node are selected these actions only work when the distance in pixels is not too high.

comment:4 by GerdP, 2 months ago

I think the relevant preference is mappaint.segment.snap-distance . Maybe you changed it to a lower value?

comment:5 by skyper, 2 months ago

Resolution: invalid
Status: newclosed

Damn, I did not expect it to be only 10 pixels per default. What is the reason for such a low number?
At least with the target way selected it would be useful to have a much higher threshold.

in reply to:  5 comment:6 by stoecker, 2 months ago

Replying to skyper:

Damn, I did not expect it to be only 10 pixels per default. What is the reason for such a low number?

Experience and testing. Thought with modern screen resolutions that may have changed...

in reply to:  4 comment:7 by skyper, 2 months ago

Replying to GerdP:

I think the relevant preference is mappaint.segment.snap-distance .

My problem with this preference is that it is used in several places. E.g. I do not want to set a higher value for snapping onto ways adding nodes but only for the two actions mentioned above.

Last edited 2 months ago by skyper (previous) (diff)

comment:8 by GerdP, 2 months ago

I agree that the different actions require different values. The relevant code is in NavigatableComponent.getNearestWaySegmentsImpl() and this is called by several different actions.
It should be possible to add a parameter that specifies the preference which should be used.

comment:9 by skyper, 2 months ago

See #23872.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.