Way Split shows superfluous warning of splitting way with possible referrers

[anonymous]

What steps will reproduce the problem?

1. Select node on a completely downloaded way.
2. Press P.

What is the expected result?

The way is split without issue.

What happens instead?

JOSM displays the warning that I'm about to split a way that may have undownloaded referrers, which might lead to broken relations.

Please provide any additional information below. Attach a screenshot if possible.

The attached file shows that the way I'm trying to split is very much downloaded in its entirety. The way doesn't even belong to any relation.
I know I can hide the warning, but I'd rather want it to warn me when I'm about to actually split a relation. Crying wolf and all that.

Revision:19128
Build-Date:2024-07-06 10:12:45

Identification: JOSM/1.5 (19128 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Enterprise LTSC 2021 21H2 (19044)
Memory Usage: 1184 MB / 8152 MB (326 MB allocated, but free)
Java version: 21.0.3+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1200x32bpp@59Hz (scaling 1.00×1.00) \Display1 1920x1080x32bpp@60Hz (scaling 1.00×1.00) \Display2 1360x768x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19128, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (36226)
+ ImportImagePlugin (36184)
+ ImproveWay (32)
+ PicLayer (1.0.3)
+ PolygonCutOut (v0.7.3)
+ SimplifyArea (36209)
+ alignways (36205)
+ apache-commons (36273)
+ buildings_tools (36226)
+ changeset-viewer (0.0.7)
+ contourmerge (v0.2.1)
+ ejml (36176)
+ ext_tools (36126)
+ geotools (36273)
+ importvec (36200)
+ jackson (36273)
+ jaxb (36118)
+ jts (36004)
+ log4j (36273)
+ measurement (36256)
+ merge-overlap (36178)
+ pdfimport (36205)
+ reltoolbox (36280)
+ reverter (36256)
+ routing (36226)
+ splinex (36126)
+ turnlanes (36206)
+ turnrestrictions (36226)
+ undelete (36226)
+ utilsplugin2 (36241)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ <josm.pref>\fi-sv.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Validator rules:
+ <josm.pref>\my.validator.mapcss

Last errors/warnings:
- 00000.340 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF'
- 00000.341 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.341 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00001.389 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00008.159 E: unable to find dependency jaxb for plugin geotools

[taylor.smock]

How are you downloading data? If you are downloading data using overpass, then that is the problem.

If you loaded a saved file, then since we do not know if anything has changed on the server, that is the problem.

[skyper]

I had a similar situation, the day before yesterday. Unfortunately, I had no time to figure out what is going on. I guess that modifying the way by adding/deleting nodes did change the flag but I have to try to reproduce. Anyway, I only had only downloaded from server and there was no local file involved.

[taylor.smock]

@skyper: If you can repro, that would be ideal. I just tried adding/removing nodes to a way fully inside the download area and another way that was partially inside the download area. I was unable to reproduce.

[anonymous]

Replying to taylor.smock:

How are you downloading data? If you are downloading data using overpass, then that is the problem.

If you loaded a saved file, then since we do not know if anything has changed on the server, that is the problem.

That way in the screenshot was a fresh download the standard way from OSM, not Overpass. But, I did actually have some local data, some imported polygons from a dataset. But I'm unable to repro now, even when copypasting those polygons to a downloaded layer.

I'm also getting UI glitches now and again, which seems to be connected to editing relations, or relation windows, so I have to save sessions, delete the cache and restart JOSM to continue. Maybe at that point the downloaded layer became a local file.

[taylor.smock]

I'm also getting UI glitches now and again, which seems to be connected to editing relations, or relation windows

You probably have a driver issue. Someone else had that problem and reported that uninstalling and reinstalling their graphics drivers worked. See wiki:Download#MicrosoftWindowsGraphics for details.

Maybe at that point the downloaded layer became a local file.

We do not persist the fact that an object was fully downloaded when we save to file. While we didn't consider it at the time, I am not convinced that persisting the state to disk would be a wise idea, specifically because it can become stale very quickly. You can fix this by loading the file and then File -> Update data.

[SekeRob]

Regrettably something did change somewhere between the last 2-3 stable releases. Case in point, roundabouts that are drawn awfully not round or become none circular due editing and dragging, a long bend swaying left and right as mapped, but not in the imagery. Selecting the object and hitting O was enough to fix this, now I'm getting a message about there could be unloaded 'referring to' something along those lines * *. Even when re-downloading the whole area, the message persists. For a cut up roundabout it used to work to quickly trace a full ring and hit O... no more. Maybe relations are affected which I don't think is relevant since the object is related to a route, not the individual nodes.

I've gone to the silly actual to open a clean layer, download the affected area only and do the O and then it works, then merge that to the working layer, no merge issues. Zero conflict reports on uploading.

• * Found a footway ring in a park downloaded yesterday and on O it says "One or more nodes involved in this action may have additional referrers"... There are absolutely none but the park paths leading to the ring who's at most attaching node would have moved by rounding the ring, no relations at all . Redownloading the area and it works. Think if this on uploading causes a conflict report that's fine, but this action blocking is rather premature IMHO and severely interrupting the work flow.

[taylor.smock]

I have been unable to reproduce with several roundabouts in my local area. (​osmwww:way/1295125143 and ​osmwww:way/121039433).

If you loaded the data from a file, please use File -> Update data.

[SekeRob]

As per my comment, eventually can get around this with great effort, the Update Data kind of a non-starter as these larger datasets easily take me past fetching 2 cups of coffee. Deleting and doing it anew is quicker.

Friday evening I mapped brand new field & track athletics stadium but did not finish. Uploaded the works so-far. Saturday morning wanted to add the various disciplines, one inner ring part of a steeple chase loop. Drew the half round line which connected both ends to the track loop, hit O, no go, same message. Downloaded the small area and it went through. An isolated area connected to nothing and still. This wasn't and now it is. All the other newish messages warn that one or the other may have un-downloaded referrers, even sometimes offers to download the missing pieces, but you can get past since I KNOW I'm the only one mapping landcover in this way outback and certainly I look in the morning if by chance anyone else wandered in which are, if at all, the mtb riders and hikers. Anyway, you cant' replicate, I can at will for anything that needs rounding that's been downloaded or added say 1/4 - 1/2 a day before.

[taylor.smock]

Anyway, you cant' replicate, I can at will for anything that needs rounding that's been downloaded or added say 1/4 - 1/2 a day before.

Was JOSM kept open for that 1/4-1/2 day? Or did you close it and reopen it?

[taylor.smock]

For roundabouts, see #23808.

[SekeRob]

"Was JOSM kept open for that 1/4-1/2 day? Or did you close it and reopen it?"

Yes. 4GB memory occupation to store to disk when hibernating for the night is a big chunk.

[jfd553]

Replying to SekeRob:

Regrettably something did change somewhere between the last 2-3 stable releases.

I tend to agree. I've been aligning nodes in a circle for years, in complex situations, and have never received any error/warning messages except recently.

[anonymous]

Replying to taylor.smock:

I'm also getting UI glitches now and again, which seems to be connected to editing relations, or relation windows

You probably have a driver issue. Someone else had that problem and reported that uninstalling and reinstalling their graphics drivers worked. See wiki:Download#MicrosoftWindowsGraphics for details.

Maybe at that point the downloaded layer became a local file.

We do not persist the fact that an object was fully downloaded when we save to file. While we didn't consider it at the time, I am not convinced that persisting the state to disk would be a wise idea, specifically because it can become stale very quickly. You can fix this by loading the file and then File -> Update data.

If I do Update Data on a saved session with a saved layer, I still get a message about undownloaded referrers when I do Join overlapping Areas on completely new polygons, in the following situation:

I split a large forest polygon, and that polygon is now new (id: 0), but it has old nodes that do have id's.
I drew a farmland polygon that shares nodes with that forest polygon, and some of those nodes are old.
I drew a second farmland polygon next to the first one, and I want to merge the farmland polygons into a single one by joining overlapping areas.

Update Data does not make that message go away, and neither does re-downloading that area from Download from OSM.
The only way to make that message not appear is to select all the old nodes and do Download Parent Ways.

Can confirm, though, that splitting old roads does not make that message appear after updating data.

[anonymous]

Note to the previous comment: the entirety of the split forest polygon was well inside the downloaded area. I know not to add or edit anything outside the downloaded area.

[taylor.smock]

In 19175/josm:

Fix #23846: Setting all referrers downloaded doesn't happen if the target object has been modified

This may also fix (or partially fix) #23808 and #23810.