Modify

Opened 9 months ago

Closed 6 months ago

Last modified 6 months ago

#23701 closed enhancement (fixed)

[Patch] Support for revert multiple changesets in Remote Control

Reported by: TrickyFoxy Owned by: team
Priority: normal Milestone:
Component: Plugin reverter Version:
Keywords: remote control Cc:

Description

The plugin supports the ability to revert multiple changesets, but you can only revert one changeset using Remote Control.

The only question is: should this be a new parameter of the form ids=1,2,3 or can the allowed values ​​of the current id parameter be expanded?

Related code:
https://josm.openstreetmap.de/browser/osm/applications/editors/josm/plugins/reverter/src/reverter/RevertChangesetHandler.java

Attachments (2)

Multiple_revert.patch (3.4 KB ) - added by TrickyFoxy 9 months ago.
Support_for_revert_multiple_changesets_in_Remote_Control.patch (2.6 KB ) - added by TrickyFoxy 9 months ago.

Download all attachments as: .zip

Change History (7)

by TrickyFoxy, 9 months ago

Attachment: Multiple_revert.patch added

comment:1 by skyper, 9 months ago

Keywords: remote control added
Summary: Support for revert multiple changesets in Remote Control[Patch] Support for revert multiple changesets in Remote Control

comment:2 by stoecker, 9 months ago

Splitting the argument in id and ids is a bad design. It's not logical why that should be used and it's not really compatible. Keep "id" and only extend the support by accepting more than one value.

comment:3 by TrickyFoxy, 9 months ago

Thanks for your comment. The code actually looks better with this approach. The idea with ids is inspired by the OSM API :)

comment:4 by taylor.smock, 6 months ago

Resolution: fixed
Status: newclosed

In 36319/osm:

Fix #23701: Support for revert multiple changesets in Remote Control (patch by TrickyFoxy, modified)

Modifications are as follows:

  • Lint cleanups
  • Add remote control checkbox for reverter to preferences

comment:5 by taylor.smock, 6 months ago

In 36321/osm:

See #23701 (dist): Support for revert multiple changesets in Remote Control (patch by TrickyFoxy, modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.