Reverter plugin reverts nodes that were not modified by the reverted changeset

[bxl-forever]

What steps will reproduce the problem?

1. Find a changeset that contains changes to a way
2. Revert through the reverter plugin
3. Select modified nodes

What is the expected result?

If the changeset modified some nodes, reverts them normally, but leave other nodes unchanged.

What happens instead?

Whereas the way itself is properly reverted (i.e. tags and list of nodes is correctly set to its previous version), nodes that are part of this way are also set to their location and tags from one version earlier. The problem is that it does this for *all* nodes of the way, including nodes that were not modified by the bad changeset.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-03-12 17:31:19 +0100 (Tue, 12 Mar 2024)
Revision:19017
Build-Date:2024-03-13 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19017 en) Linux Arch Linux
Memory Usage: 312 MB / 3926 MB (158 MB allocated, but free)
Java version: 21.0.2+13, N/A, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatLightLaf
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (36176)
+ flatlaf (36176)
+ measurement (36200)
+ pt_assistant (632)
+ reverter (36230)
+ undelete (36226)
+ utilsplugin2 (36226)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

[bxl-forever]

Example with illustrations about how to reproduce

[bxl-forever]

reverter 36201 did not have this problem; reverting works fine after temporarily downgrading. The issue seems to have been caused by the latest commits.

[taylor.smock]

This would have been done by r36230/osm. I'm looking into it.

[taylor.smock]

In 36233/osm:

Fix #23582: Reverter plugin reverts nodes that were not modified by the reverted changeset

[bxl-forever]

Many thanks for the fix!

[taylor.smock]

In 36234/osm:

Fix #23582 (dist): Reverter plugin reverts nodes that were not modified by the reverted changeset

[taylor.smock]

No problem. That you for writing a good bug report. I don't think you needed to go through the trouble of generating the image you attached -- you could have written something like

---

Steps to reproduce:

1. Let's say I want to revert this simple changeset. Changeset 149181932 just added a tag to a road and did not modify any node.
2. Prior to reverting, the way was a simple road made of 8 nodes.
3. When I revert the changeset fully, there are two nodes changed that were not modified in the original changeset. Prior to the last update, those two nodes were not changed.

---

In any case, it is much easier to fix something that someone tells you is a problem. Instead of just working around it. So thank you for the bug report.