[PATCH] Detect immediate exits after loading plugins

[taylor.smock]

From ​https://www.reddit.com/r/openstreetmap/comments/19f2jhk/josm_keeps_closing_by_itself/

JOSM keeps closing by itself
Hey guys, i installed lots of plugins and it tells me that some plugins needs to restart the app so i do it. But then while starting up several errors and warnings begin popping up randomly before moments later the app closes by itself. I tried to startup again and reinstall the app to delete it's data, but the same problem continues to happen again and again, and now i don't know how to fix it. Can you please help solve this problem?

What we should do:

1. Set some kind of persistent (preference?) variable to indicate that we have started
2. Increment that variable at most <x> (3?) times before we offer to reset JOSM after filing a bug report.
3. If JOSM finishes startup, reset the preference variable

I think doing (1) immediately after setting up preferences would be ideal, and then (3) after all startup initialization tasks have finished.

[GerdP]

Sounds okay to me. Just keep in mind that devs stop execution in all kinds of stages while debugging. I also often start a 2nd instance of JOSM by mistake and stop that 2nd instance asap. But of course I know what to do with a corrupted josm home directoy since I have many backups...

[taylor.smock]

For the reset offer, I was thinking of an option pane that asked "JOSM has failed to finish startup <x> times. Do you want to try resetting JOSM?" instead of just resetting without asking. This check would be the first thing that happens after config setup.

I was also thinking of setting the min interrupted startups to something that most users won't accidentally hit (by force closing JOSM during startup, for example). I think 3 failed starts is a good initial number.

[GerdP]

| 3 failed
Yes, I think Windows also uses that number. After three failed starts a minimal console starts which allows to repair the installation or install a backup etc but also offers to continue a normal start.

[taylor.smock]

In 19012/josm:

Fix #23437: Offer to reset JOSM if JOSM fails to finish startup multiple times