GitHub CI: test suite failing with Java 8 on Windows

[gaben]

​https://github.com/JOSM/josm/actions/runs/7399195247/job/20130043825#step:6:697

[junitlauncher] Running org.openstreetmap.josm.gui.MainApplicationTest
[junitlauncher] #
[junitlauncher] # A fatal error has been detected by the Java Runtime Environment:
[junitlauncher] #
[junitlauncher] #  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x0000000071773265, pid=7360, tid=0x00000000000014dc
[junitlauncher] #
[junitlauncher] # JRE version: OpenJDK Runtime Environment (Zulu 8.74.0.17-CA-win64) (8.0_392-b08) (build 1.8.0_392-b08)
[junitlauncher] # Java VM: OpenJDK 64-Bit Server VM (25.392-b08 mixed mode windows-amd64 compressed oops)
[junitlauncher] # Problematic frame:
[junitlauncher] # V  [jvm.dll+0x123265]
[junitlauncher] #
[junitlauncher] # Core dump written. Default location: D:\a\josm\josm\hs_err_pid7360.mdmp
[junitlauncher] #
[junitlauncher] # An error report file with more information is saved as:
[junitlauncher] # D:\a\josm\josm\hs_err_pid7360.log
[junitlauncher] #
[junitlauncher] # If you would like to submit a bug report, please visit:
[junitlauncher] #   http://www.azul.com/support/
[junitlauncher] #

BUILD FAILED
D:\a\josm\josm\build.xml:532: The following error occurred while executing this line:
D:\a\josm\josm\build.xml:458: Forked test(s) failed with an exception

The dump files are not available in the artifacts.

[taylor.smock]

A couple of notes: We aren't planning on (officially) supporting Java 8 for much longer (see #17858); we may continue building some parts of JOSM for Java 8, if only to give users a better message and steps to take. But someone (me, probably) is going to have to code that.

It would be nice to debug that issue, but I suspect it is an issue with the JDK, not JOSM.

The test started failing with ​https://github.com/JOSM/josm/actions/runs/6732781287/job/18300131575 (the previous build, ​https://github.com/JOSM/josm/actions/runs/6712127360, passed on Windows). So that test started to fail with r18893.

We should be capturing dump files, the problem is figuring out where they'll be. It is printed to console, but the console output isn't saved to file.

[gaben]

It's a JDK issue for sure :)

Maybe if you can add capturing dump files if happens anytime in the future is enough and we can close the ticket.

[taylor.smock]

In 18936/josm:

Fix #23416: When GitHub CI fails, the hs_err dumps should be included in the test artifacts

[taylor.smock]

the problem is figuring out where they'll be

It turns out the path (D:\a\josm\josm\) is to the working directory, so it was a fairly easy "fix".