MacOS.zip does not build

[stoecker]

Since r18896 MacOs doesn't build zip file anymore.

​https://github.com/JOSM/josm/releases/tag/18895 ...
​https://github.com/JOSM/josm/releases/tag/18896

[taylor.smock]

It looks like it is due to signjar failing.

Looking at the job outputs (see ​https://github.com/JOSM/josm/actions/runs/7091380242/job/19331552037 )

dist:
     [echo] Revision 18905
      [jar] Building jar: /Users/runner/work/josm/josm/dist/josm-custom.jar
  [signjar] Signing JAR: /Users/runner/work/josm/josm/dist/josm-custom.jar to /Users/runner/work/josm/josm/dist/josm-custom.jar as 
  [signjar] jarsigner error: java.lang.RuntimeException: keystore load: keystore password was incorrect

EDIT: Relevant code from build.xml:

        <!-- Sign jar if all environment variables are set -->
        <signjar jar="${dist.jar}" alias="${env.SIGN_ALIAS}" tsaurl="${env.SIGN_TSA}"
            keystore="${env.SIGN_KEYSTORE}" storepass="${env.SIGN_STOREPASS}" keypass="${env.SIGN_KEYPASS}" if:set="sign.jar" />

We probably need to update env variables on GitHub.

[stoecker]

Probably I added wrong password (can't check, GitHub secrets are write only). Replaced them again and triggered rebuild.

[stoecker]

Ticket #23336 has been marked as a duplicate of this ticket.

[stoecker]

Hmm. Password seems correct now (last letter was missing :-), but it seems there are secret secret variables (i.e. I didn't get displayed that they exist), so I didn't update them.

[taylor.smock]

Assuming we didn't change the keystore password (I think this would be SIGN_STOREPASS), it should be changeit, IIRC.

[stoecker]

In 18906/josm:

add missing APPLE_ID, see #23335

[stoecker]

Replying to taylor.smock:

Assuming we didn't change the keystore password (I think this would be SIGN_STOREPASS), it should be changeit, IIRC.

Assumption wrong ;-) When I make new keys I also use new passwords...

And these are done with this command

alias mkpasswd='perl -e "\$_=qx(dd if=/dev/urandom count=1 2>/dev/null);s/[^A-Za-z0-9]//g;\$n=\$ARGV[0]||15;/(.{\$n})/;print qq(Your new password: \$1\n)"'

which outputs a proper 15 letter alphanumeric password.

Note: That command is meant to be short. It wastes a lot of randomness. That's ok as long as it's used seldom!