Modify

Opened 17 years ago

Closed 17 years ago

#233 closed defect (fixed)

Align Nodes in Circle broken

Reported by: framm Owned by: imi
Priority: minor Milestone:
Component: unspecified Version:
Keywords: Cc:

Description

When you "align nodes in circle", they should form a real circle on the earth's surface, not a circle in whatever projection is currently active.

Attachments (2)

truecircles.diff (1.7 KB ) - added by tom_evans_a@… 17 years ago.
Patch for decent circles by changing the distance calculation.
truecircles.2.diff (1.8 KB ) - added by tom_evans_a@… 17 years ago.
decent circles; tried to fix line ending problems in previous patch

Download all attachments as: .zip

Change History (6)

comment:1 by gercokees@…, 17 years ago

I agree with this, it should form a circle on the earth's surface, not in whatever projection is currently active.....

comment:2 by gercokees@…, 17 years ago

For example:
These should are circles in JOSM:
http://www.openstreetmap.org/?lat=51.97387&lon=4.06199&zoom=15&layers=0BFT

but here the are a bit "eggy"....

by tom_evans_a@…, 17 years ago

Attachment: truecircles.diff added

Patch for decent circles by changing the distance calculation.

in reply to:  description comment:3 by tom_evans_a@…, 17 years ago

Attached a patch for this. Algorithm is not a fully correct 3D solution, but easily good enough for the job. (drawing roundabouts, not circles round continents)

Tested by saving spiky circle in .osm file, aligning to circle in one projection and saving. Then re-opening in the other projection, re-aligning and comparing to the other saved result. The nodes go bang on top of one another.

This is the first patch I've sent in to trac, so not sure if I'm supposed to do anything else to get somebody to look at putting it into svn?

by tom_evans_a@…, 17 years ago

Attachment: truecircles.2.diff added

decent circles; tried to fix line ending problems in previous patch

comment:4 by tom_evans_a@…, 17 years ago

Resolution: fixed
Status: newclosed

Fixed in r564.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain imi.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.