Opened 17 years ago
Closed 17 years ago
#233 closed defect (fixed)
Align Nodes in Circle broken
Reported by: | framm | Owned by: | imi |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | unspecified | Version: | |
Keywords: | Cc: |
Description
When you "align nodes in circle", they should form a real circle on the earth's surface, not a circle in whatever projection is currently active.
Attachments (2)
Change History (6)
comment:1 by , 17 years ago
comment:2 by , 17 years ago
For example:
These should are circles in JOSM:
http://www.openstreetmap.org/?lat=51.97387&lon=4.06199&zoom=15&layers=0BFT
but here the are a bit "eggy"....
by , 17 years ago
Attachment: | truecircles.diff added |
---|
Patch for decent circles by changing the distance calculation.
comment:3 by , 17 years ago
Attached a patch for this. Algorithm is not a fully correct 3D solution, but easily good enough for the job. (drawing roundabouts, not circles round continents)
Tested by saving spiky circle in .osm file, aligning to circle in one projection and saving. Then re-opening in the other projection, re-aligning and comparing to the other saved result. The nodes go bang on top of one another.
This is the first patch I've sent in to trac, so not sure if I'm supposed to do anything else to get somebody to look at putting it into svn?
by , 17 years ago
Attachment: | truecircles.2.diff added |
---|
decent circles; tried to fix line ending problems in previous patch
I agree with this, it should form a circle on the earth's surface, not in whatever projection is currently active.....