Modify

Opened 16 months ago

Closed 16 months ago

Last modified 13 months ago

#23228 closed enhancement (fixed)

[TaggingPreset][Translation] Add different context to translation of "left", "right" and "both"

Reported by: KorneySan Owned by: team
Priority: normal Milestone: 23.11
Component: Internal preset Version:
Keywords: left right both Cc:

Description

Please add to translation more context for words "left", "right" and "both". It should be at least three of them.

For "left" and "right" they are:
"left"/"right" meaning the side of object: "left part of the house"
"left"/"right" meaning certain disposition ("on the left"): "bus bay on the left side of the line"
"left"/"right" meaning certain direction ("to the left"): "turn left on the next crossing"
Or you can fix it by use some chunks and items in existing context "sidewalk", for example:
№273 (side context) chunks and items as №5032 (disposition context)
№274 chunks and items as №5033

For "both" they also are:
"both" meaning the sides of object: "both edges of the wall"
"both" meaning certain disposition ("on both"): "bus bay on both sides of the line"
"both" meaning certain direction ("in both"): "drive in both directions"
As above, some chunks and items should change their context:
№5029 (except traffic signal direction) should go to №5031 (disposition)

Attachments (0)

Change History (13)

comment:1 by stoecker, 16 months ago

The numbers have no meaning, they change permanently. Please tell the places where strings occur (file, line number, as shown in the string description) and also which should separated by context and what the context could be named.

We know that contexts can mismatch, but we only care for these if there a real conflicts, otherwise it would be an extreme additional effort to translate.

comment:2 by KorneySan, 16 months ago

Sorry. The number is the line number in Launchpad translation site.
Example:

273.

English:

left

SHORTCUT(Move objects up, core:moveup, SHIFT, UP)
* Move left
chunk "highway_yesno_incline_oneway_lit_width_busbay_sidewalk" combo combo "Bus bay" combo "Bus bay" display value
chunk "placement_shoulder" combo combo "Shoulder" combo "Shoulder" display value
item "Highways/Streets/Residential" group "Highways/Streets" combo combo "Bus bay" combo "Bus bay" display value
item "Highways/Streets/Bicycle Road" group "Highways/Streets" combo combo "Bus bay" combo "Bus bay" display value

Located in ../core/src/org/openstreetmap/josm/actions/MoveAction.java:40 build/trans_presets.java:53 build/trans_presets.java:64 build/trans_presets.java:689 build/trans_presets.java:720

Description for it means that it is side translation, which is not suitable for "Bus bay" and "Shoulder" chunks/items where disposition translation applied. They should be assigned to

5032.

English:  	
left

Context: 		
sidewalk

chunk "highway_yesno_incline_oneway_lit_width_busbay_sidewalk" combo combo "Sidewalk" combo "Sidewalk" display value
item "Highways/Streets/Residential" group "Highways/Streets" combo combo "Sidewalk" combo "Sidewalk" display value
item "Highways/Streets/Bicycle Road" group "Highways/Streets" combo combo "Sidewalk" combo "Sidewalk" display value

Located in build/trans_presets.java:54 build/trans_presets.java:690 build/trans_presets.java:721

where disposition translation exists.
And so on.

Context mismatch leads to wrong values/descriptions display in preset dialogs. For example, translated "Bus bay" field in "Highway" presets looks like "turn left" instead "on the left side" and can confuse users.

Last edited 16 months ago by KorneySan (previous) (diff)

comment:3 by stoecker, 16 months ago

In 18860/josm:

see #23228 - add sidewalk context to Bus bay

comment:4 by stoecker, 16 months ago

That's all or is there more (Launchpad will be update somewhen this night)?

comment:5 by stoecker, 16 months ago

The name for the context is probably suboptimal, but that's normal. ;-)

in reply to:  4 ; comment:6 by KorneySan, 16 months ago

Replying to stoecker:

That's all or is there more (Launchpad will be update somewhen this night)?

Just checked 18861. "left"/"right" looks ok, "both" is not (neither at Launchpad, nor in JOSM).
Also I have updated translation yesterday, but it is not applied yet.

in reply to:  6 ; comment:7 by stoecker, 16 months ago

Replying to KorneySan:

Replying to stoecker:

That's all or is there more (Launchpad will be update somewhen this night)?

Just checked 18861. "left"/"right" looks ok, "both" is not (neither at Launchpad, nor in JOSM).

Please answer what you think needs be changed. I don't have the time to check all places to see what you mean, there is simply too much else to do. Do you mean that "sidewalk" contexts causes "both" to be wrong, so we need an own "busbay" context?

Also I have updated translation yesterday, but it is not applied yet.

That's normal. New translations are usually applied some days before a new release only.

Last edited 16 months ago by stoecker (previous) (diff)

in reply to:  7 comment:8 by KorneySan, 16 months ago

Replying to stoecker:

Please answer what you think needs be changed. I don't have the time to check all places to see what you mean, there is simply too much else to do. Do you mean that "sidewalk" contexts causes "both" to be wrong, so we need an own "busbay" context?

At the moment I think we need to wait until translation updated, because I can't check right now is the right context (and proper translation) applied or not (due to old translation in place).

comment:9 by stoecker, 16 months ago

In 18865/josm:

see #23228 - i18n update

in reply to:  9 comment:10 by KorneySan, 16 months ago

Replying to stoecker:

In 18865/josm:

see #23228 - i18n update

Looks great! Thank you very much! This issue can be closed.

For further features and i18n please keep in mind that all "side" objects (Bus bay, Sidewalk, Shoulder and so on) should use the context "sidewalk".

comment:11 by stoecker, 16 months ago

Resolution: fixed
Status: newclosed

comment:12 by skyper, 13 months ago

Component: CoreInternal preset

Should be milestone 23.11 but I cannot set past milestones.

comment:13 by stoecker, 13 months ago

Milestone: 23.11

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.