When drawing a cliff line and selecting the preset to add the cliff tag, same also land on last cliff line node.

[SekeRob]

What steps will reproduce the problem?

1. Map a bare rock zone, then draw a cliff line along one side
2. Hit S to end the drawing. The line remains selected and choose preset for cliff.
3. Apply. The natural=cliff tag sits on both line and last node of that line.

What is the expected result?

No cliff tag on final node of cliff line

What happens instead?

3 above.

Notably this has been since longer, then gets flagged during pre upload validation, but only now the penny dropped when this occurs. The same happens when drawing and arete along the edge of a polygon. It does not happen when the arete/cliff are mapped first and then re-used in drawing a polygon along that line.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-08-29 13:38:40 +0200 (Tue, 29 Aug 2023)
Revision:18822
Build-Date:2023-08-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18822 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 3300 MB / 4084 MB (1164 MB allocated, but free)
Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ KartaView (413)
+ Mapillary (2.2.0)
+ OpeningHoursEditor (36126)
+ Relation.Validation.Plugin (1.0.1)
+ RoadSigns (36126)
+ apache-commons (36034)
+ easypresets (1623509627)
+ editgpx (36126)
+ ejml (35924)
+ graphview (36126)
+ gridify (1606242219)
+ jaxb (36118)
+ kendzi3d-dev (1.0.206-SNAPSHOT-2)
+ kendzi3d-resources (0.0.2)
+ libphonenumber (8.13.21)
+ log4j (36045)
+ lwjgl (36034)
+ lwjgl-windows (36034)
+ mapwithai (814)
+ notesolver (0.5.0)
+ phonenumber (1.0.3)
+ pmtiles (36125)
+ pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
+ reltoolbox (36142)
+ reverter (36126)
+ rex (53)
+ routing (36126)
+ tageditor (36126)
+ todo (133)
+ turnlanes (36126)
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36126)
+ utilsplugin2 (36134)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ <josm.pref>/EasyPresets.xml
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&style
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
+ https://josm.openstreetmap.de/wiki/Styles/Waterways

Last errors/warnings:
- 05834.649 W: java.net.UnknownHostException: clarity.maptiles.arcgis.com
- 05834.649 W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- 05834.649 W: java.net.UnknownHostException: ecn.t2.tiles.virtualearth.net
- 05834.649 W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- 05834.649 W: java.net.UnknownHostException: clarity.maptiles.arcgis.com
- 05834.649 W: java.net.UnknownHostException: ecn.t3.tiles.virtualearth.net
- 05834.649 W: java.net.UnknownHostException: clarity.maptiles.arcgis.com
- 05834.650 W: java.net.UnknownHostException: ecn.t1.tiles.virtualearth.net
- 05834.650 W: java.net.UnknownHostException: ecn.t0.tiles.virtualearth.net
- 05834.651 W: java.net.UnknownHostException: ecn.t2.tiles.virtualearth.net

[taylor.smock]

What happens is the last node of the cliff way is still selected in (2). When you add the preset, it is added to all selected elements.

This is partly so that the Draw nodes (a) action works properly; it allows us to know whether or not the user wants to add additional nodes to a way, or start a new way.

I cannot think of a good way to fix this without breaking other functionality.

[anonymous]

Of note is that I'd tested this with drawing a stream and then the stream tag is not added to the last node.

[taylor.smock]

Of specific note with waterway=stream​ versus natural=cliff​ is that the ​osmwiki:Tag:waterway=stream is specifically valid only for ways; ​osmwiki:Tag:natural=cliff is valid for both ways and nodes.

This is why it is not a problem with waterway=stream but is a problem with natural=cliff.