Modify

Opened 20 months ago

Closed 19 months ago

Last modified 19 months ago

#23114 closed enhancement (fixed)

[PATCH] Add module-info to JMapViewer

Reported by: taylor.smock Owned by: team
Priority: normal Milestone:
Component: JMapViewer Version:
Keywords: Don-vip, stoecker Cc:

Description (last modified by taylor.smock)

I'd like to add a module-info to JMapViewer before we do another release of it.

The patch does the following:

  • Adds a module-info.java class that exports everything and requires java.desktop and java.logging.
  • Modify the build.xml file to build the module-info.class file if built under Java 9. This does require two compile runs, so ant build takes a bit longer (2s). In order to get the second javac to work, I had to delete the compiled files (except for module-info.class). While I could technically just compile module-info by itself, that removes the compile-time sanity checks for modules.

EDIT: Let me know if we don't want a module-info in JMapViewer.

Attachments (1)

23114.patch (4.0 KB ) - added by taylor.smock 20 months ago.

Download all attachments as: .zip

Change History (4)

by taylor.smock, 20 months ago

Attachment: 23114.patch added

comment:1 by taylor.smock, 20 months ago

Description: modified (diff)
Type: defectenhancement

comment:2 by taylor.smock, 19 months ago

Resolution: fixed
Status: newclosed

In 36139/osm:

Fix #23114: Add module-info to JMapViewer

comment:3 by taylor.smock, 19 months ago

In 36141/osm:

Release v2.17: See #19064, #23113, #23114

  • #19064: Resolve tools and libraries using Apache Ivy
  • #23113: Add default methods to JMapViewer TileSource interface
  • #23114: Add module-info to JMapViewer

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.