Modify ↓
#23114 closed enhancement (fixed)
[PATCH] Add module-info to JMapViewer
Reported by: | taylor.smock | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | JMapViewer | Version: | |
Keywords: | Don-vip, stoecker | Cc: |
Description (last modified by )
I'd like to add a module-info
to JMapViewer before we do another release of it.
The patch does the following:
- Adds a
module-info.java
class that exports everything and requiresjava.desktop
andjava.logging
. - Modify the
build.xml
file to build themodule-info.class
file if built under Java 9. This does require two compile runs, soant build
takes a bit longer (2s). In order to get the secondjavac
to work, I had to delete the compiled files (except formodule-info.class
). While I could technically just compilemodule-info
by itself, that removes the compile-time sanity checks for modules.
EDIT: Let me know if we don't want a module-info
in JMapViewer.
Attachments (1)
Change History (4)
by , 20 months ago
Attachment: | 23114.patch added |
---|
comment:1 by , 20 months ago
Description: | modified (diff) |
---|---|
Type: | defect → enhancement |
comment:2 by , 19 months ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In 36139/osm: