Notify users that a plugin requires a newer Java version

[GOwin]

What steps will reproduce the problem?

1. I upgraded to the latest JOSM version 18789, on Pop OS!. After the upgrade the to-do plugin window disappeared (I use it often.), and is no longer found in the menu
2. Keyboard shortcut doesn't activate it.

What is the expected result?

The to-do window should be available, and also be accessible from the menu.

What happens instead?

It's gone, I couldn't activate it though my system says it's installed. In my previous JOSM version, I've been using it fine, and this only happened after the upgrade.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-31 18:33:06 +0200 (Mon, 31 Jul 2023)
Revision:18789
Build-Date:2023-08-01 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18789 en) Linux Pop!_OS 22.04 LTS
Memory Usage: 746 MB / 3880 MB (262 MB allocated, but free)
Java version: 11.0.20+8-post-Ubuntu-1ubuntu122.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatLightLaf
Screen: :0.0 1360×768 (scaling 1.00×1.00)
Maximum Screen Size: 1360×768
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: XFCE
Java package: openjdk-11-jre:amd64-11.0.20+8-1ubuntu1~22.04
fonts-noto: fonts-noto:all-20201225-1build1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]

Plugins:
+ MapRoulette
+ Mapillary (2.1.5)
+ OpeningHoursEditor (36079)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36097)
+ easypresets (1623509627)
+ ejml (35924)
+ flatlaf (36036)
+ geotools (36068)
+ imagery_offset_db (36079)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ mapwithai
+ mbtiles (v2.6.1)
+ measurement (36097)
+ opendata (36097)
+ reverter (36066)
+ tageditor (36097)
+ terracer (36079)
+ todo
+ turnlanes-tagging (0.0.5)
+ turnrestrictions (36097)
+ utilsplugin2 (36097)
+ waydownloader (36097)

Tagging presets:
+ <josm.userdata>/EasyPresets.xml
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksPlus&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapillaryDetections&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/CyclewaysStylingBNA&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- 00010.842 W: Plugin todo requires Java version 17. The current Java version is 11. You have to update Java in order to use this plugin.
- 00010.842 W: Plugin mapwithai requires Java version 17. The current Java version is 11. You have to update Java in order to use this plugin.
- 00012.758 E: Failed to locate image 'PHadrr.png'
- 00012.759 W:  null: Could not get presets icon PHadrr.png
- 00012.760 E: Failed to locate image 'icons/_neu.png'
- 00012.760 W:  null: Could not get presets icon icons/_neu.png
- 00012.772 E: Failed to locate image 'PHadrr.png'
- 00012.773 W:  Sangguniang Barangay: Could not get presets icon PHadrr.png
- 00012.773 E: Failed to locate image 'icons/_neu.png'
- 00012.773 W:  PSA tags: Could not get presets icon icons/_neu.png

[GOwin]

This issue occured while using an older version of Java. After an upgrade to openjdk-17, the "missing" to-do window re-appeared.

I was ignoring the java upgrade warning because I interpreted it as still having support for 11, but it's going away soon.

[GOwin]

This issue occurred while using an older version of Java. After an upgrade to openjdk-17, the "missing" to-do window re-appeared.

I was ignoring the java upgrade warning because I interpreted it as still having support for 11, but it's going away "soon."

[SekeRob]

Don't know if it is part of this plugin whchi works for me. When I add todo's and close JOSM, then close and restart/reopening the previous session in WIP, all todo's are gone. I'd hoped these could be carried over.

[taylor.smock]

@GOwin: Thank you for reporting this bug -- I've got a fix (I saw some people having issues with it last week), and I was waiting for the release to settle for a few days. As soon as I go through the tickets that were reported over the weekend, I'll be applying the fix for this problem. Assuming there were no breaking bugs reported.

@SekeRob: You probably want to look at #17052. When I was looking at it previously, it needed changes to JOSM core -- the current session save functionality only saves layer information.

[taylor.smock]

In 18790/josm:

Fix #23103, see #17858: Notify users that a plugin requires a newer Java version

We were previously only logging a warning if a plugin required a newer Java
version. We additionally needed to update the download link generation for Azul
and sync the next minimum Java version with that used by the JOSM wiki check.

There was also a help topic that linked to a dead page (which was also
unavailable in the internet archive).

[taylor.smock]

I was ignoring the java upgrade warning because I interpreted it as still having support for 11, but it's going away soon.

JOSM core will continue to support Java 8 until we manage to move enough people off of Java 8 (<5% was the usual percentage; this time it might be 10% or higher).

Anyway, I've been converting plugins I do a significant amount of work on to Java 17, mostly because there are some nice things in newer versions of Java. It also serves as a way to get people to update their Java versions.