Todo list Plugin - Mark done is always marking the first item on the list

[Patrik_B]

I am not sure if this is a bug or a feature. It wasn't like this until the update few months back. When I mark an item/object from the todo list as done it always removes the very first object, not the one I have currently selected.

What steps will reproduce the problem?

1. Add multiple objects into the todo list
2. Select item on the list that is not on the first position
3. Click on Mark done button

What is the expected result?

The object from the list that I have currently selected will be removed from the list.

What happens instead?

The very first object on the list will be removed from the list.

Please provide any additional information below. Attach a screenshot if possible.

Here is recorded GIF of JOSM ​https://gifyu.com/image/ScqYs

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-06 21:00:41 +0200 (Thu, 06 Jul 2023)
Revision:18772
Build-Date:2023-07-07 01:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18772 en_GB) Windows 11 64-Bit
OS Build number: Windows 10 Home 2009 (22621)
Memory Usage: 1150 MB / 4060 MB (616 MB allocated, but free)
Java version: 17.0.2+8-86, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1280×1024 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1250
System property sun.jnu.encoding: Cp1250
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dsun.java2d.noddraw=true]
Dataset consistency test: No problems found

Plugins:
+ MapRoulette (21)
+ Mapillary (2.1.5)
+ apache-commons (36034)
+ buildings_tools (36097)
+ conflation (0.6.11)
+ ejml (35924)
+ geotools (36068)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ mapathoner (1.5.1)
+ markseen (14)
+ opendata (36097)
+ scripting (v0.2.9)
+ todo (128)
+ utilsplugin2 (36097)

Map paint styles:
+ https://github.com/MissingMaps/josm_styles/archive/master.zip
+ https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
+ D:\Mapathon\special\moje\My_painting_style.css
- https://gitlab.com/peculiar-theater/mapcss/-/archive/main/mapcss-main.zip?path=tm-taskgrid
- https://gitlab.com/peculiar-theater/mapcss/-/archive/main/mapcss-main.zip?path=osm-meta
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
- https://github.com/osmlab/applepaintstyles/archive/main.zip
- D:\Mapathon\special\moje\Mapathon_beginner_paint_style\Mapathon_paint_style-ZALOHA.css
- https://raw.githubusercontent.com/Patrik-Br/MapathonPaintStyle/main/Mapathon_paint_style.css

Validator rules:
- D:\Mapathon\special\moje\validation_rule\My_validator_rules.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/ValidatingBuildingsInHOTTMProjects&zip=1

[Patrik_B]

Unrelated but second thing that I was used to use before the mentioned update - when I delete (in the data layer) an object that I have in the todo list it removes it from the list as well. I agree, it makes sense (before that update it stayed there). The only downside is that I am used to using shortcuts to mark item as done but when I delete an object the shortcut doesn't work because the item got removed from the list so now it isn't selecting any item on the list.

[taylor.smock]

When I mark an item/object from the todo list as done it always removes the very first object, not the one I have currently selected.

This is a bug.

[taylor.smock]

I've got a fix, which should be deployed as soon as the PR checks finish and I merge it. So probably ~30 minutes from now.