Modify

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#23081 closed defect (fixed)

NoSuchElementException in ConflictDialog.ResolveToAction#actionPerformed

Reported by: SomeoneElse2 Owned by: taylor.smock
Priority: normal Milestone: 23.07
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Try and revert 138962397
  2. 125 conflicts
  3. Resolve to my version
  4. You have encountered a bug in JOSM

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

I'm just logging this because I was asked to.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-06 21:00:41 +0200 (Thu, 06 Jul 2023)
Revision:18772
Build-Date:2023-07-07 01:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18772 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 460 MB / 3026 MB (101 MB allocated, but free)
Java version: 20.0.1+9-29, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.50×1.50) \Display1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→48×48, 32×32→48×48
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ continuosDownload (1.3.4)
+ reverter (36066)
+ undelete (36066)

Last errors/warnings:
- 00000.727 W: extended font config - overriding 'filename.Malgun_Gothic=malgun.ttf' with 'MALGUN.TTF'
- 00000.731 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.732 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00021.698 E: Failed to locate image 'http://www.geoportal.segeth.df.gov.br/static/dist/img/logo_geoportal.png'
- 00621.796 W: Conflicts detected - <html>There was 1 conflict detected.</html>
- 00959.641 W: Conflicts detected - <html>There were 6 conflicts detected.</html>
- 01226.090 W: Conflicts detected - <html>There were 3 conflicts detected.</html>
- 01508.779 W: Conflicts detected - <html>There were 125 conflicts detected.</html>
- 01565.785 E: Handled by bug report queue: java.util.NoSuchElementException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (36) of main
java.util.NoSuchElementException
	at java.base/java.util.ArrayList$Itr.next(ArrayList.java:970)
	at org.openstreetmap.josm.command.SequenceCommand.<init>(SequenceCommand.java:59)
	at org.openstreetmap.josm.command.SequenceCommand.<init>(SequenceCommand.java:68)
	at org.openstreetmap.josm.gui.dialogs.ConflictDialog$ResolveToAction.actionPerformed(ConflictDialog.java:524)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2314)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:407)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.AbstractButton.doClick(AbstractButton.java:374)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1029)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1073)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6620)
	at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3398)
	at java.desktop/java.awt.Component.processEvent(Component.java:6385)
	at java.desktop/java.awt.Container.processEvent(Container.java:2266)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4995)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4827)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4575)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4827)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:775)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:98)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Attachments (0)

Change History (6)

comment:1 by taylor.smock, 19 months ago

Milestone: 23.07
Owner: changed from team to taylor.smock
Status: newassigned
Summary: You have encountered a bug in JOSMNoSuchElementException in ConflictDialog.ResolveToAction#actionPerformed

comment:2 by taylor.smock, 19 months ago

Well, something changed since your ticket was opened. I got 333 conflicts, and no exception. But I think I know how to fix it. I just have to verify it.

comment:3 by taylor.smock, 19 months ago

Resolution: fixed
Status: assignedclosed

In 18783/josm:

Fix #23081: NoSuchElementException in ConflictDialog.ResolveToAction#actionPerformed

This occurs when one of the Resolve to (my|their) versions actions is called
when no conflict is selected.

There are two distinct bugs:

  • isConflictSelected did not check to make certain that the selection index made sense
  • ResolveActions were not enabled/disabled when the popup menu became visible, depending upon whether the current selection was valid

comment:4 by gaben, 19 months ago

(There is a probably unintended indentation change in line 539.)

comment:5 by taylor.smock, 19 months ago

That is funny. It didn't show up in pmd checkstyle. Thanks for pointing that out -- I originally was adding an if statement to check and see if the commands were empty.

comment:6 by taylor.smock, 19 months ago

In 18784/josm:

See #23081: NoSuchElementException in ConflictDialog.ResolveToAction#actionPerformed, fix extra indentation

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain taylor.smock.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.