Error when undoing polygon reconstruction with reltoolbox

[casperkersten1@…]

What steps will reproduce the problem?

1. Find multipolygon with only unclosed outer ways of which at least one outer way is part of multiple relations or has tags.
2. Select the multipolygon and reconstruct it into a closed way
3. Try to undo this with ctrl Z

What is the expected result?

The newly made closed way disappears and the multipolygon reappears.

What happens instead?

Error message and no way to undo the change.

Please provide any additional information below. Attach a screenshot if possible.

It works for example with ​https://www.openstreetmap.org/relation/1148629
Sometimes reconstruction works fine. I've also seen that I could delete the new closed way, but trying to get it back results in an error.

Revision:18772
Build-Date:2023-07-07 10:03:44

Identification: JOSM/1.5 (18772 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Education 2009 (19045)
Memory Usage: 828 MB / 4052 MB (451 MB allocated, but free)
Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarkLaf
Screen: \Display0 1920×1080 (scaling 1.25×1.25)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18772, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Program arguments: [%UserProfile%\Downloads\export (14).osm]

Dataset consistency test:
[DELETED REFERENCED] {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} refers to deleted primitive {Way id=699396213 version=1 MVD nodes=[]}
[DELETED REFERENCED] {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} refers to deleted primitive {Way id=690067609 version=1 MVD nodes=[]}
[DELETED REFERENCED] {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} refers to deleted primitive {Way id=74590869 version=19 MVD nodes=[]}


Plugins:
+ CADTools (1008)
+ FastDraw (36097)
+ ImproveWay (32)
+ MakeParallel (v1.1.0)
+ PolygonCutOut (v0.7.3)
+ ShapeTools (1250)
+ SimplifyArea (36097)
+ apache-commons (36034)
+ apache-http (35924)
+ conflation (0.6.11)
+ ejml (35924)
+ fastdriveway (v1.0.1)
+ flatlaf (36036)
+ geotools (36068)
+ imagery_offset_db (36079)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36045)
+ measurement (36097)
+ opendata (36097)
+ osm-obj-info (66)
+ reltoolbox (36097)
+ reverter (36066)
+ terracer (36079)
+ turnrestrictions (36097)
+ undelete (36066)
+ utilsplugin2 (36097)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/NL.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://raw.githubusercontent.com/Sowa1980/Start_Data_preset/master/Start_Data_preset.zip
+ https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Fahrradverleih&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParcelLockers&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PostPartner&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/public_bookcase&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Simple_Indoor_Tagging&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://signs.tools4osm.nl/JOSM/Styles_Traffic_signs-style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Building_Levels_Labels&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Greenery&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Schools&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1

Validator rules:
+ https://raw.githubusercontent.com/Famlam/OsmMapcssValidationNL/main/netherlands.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1

Last errors/warnings:
- 00000.427 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.429 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.962 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00008.927 E: Broken tagging preset "bicycle_rental-Concretization for rental bikes" - number of items in 'display_values' must be the same as in 'values'
- 00008.928 E: Detailed information: [Lastenräder, eBikes, Fahrradanhänger] <> [cargo_bike, e-bikes, bike_trailer, yes]
- 00057.069 W: No default layer selected, choosing first layer.
- 00246.695 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} (changed by the following commands: )
- 00251.613 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} (changed by the following commands: )
- 00261.528 E: Handled by bug report queue: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} (changed by the following commands: )



=== REPORTED CRASH DATA ===
sequence_information:
 - sequence_name: Sequence: Reconstruct polygons from relation multipolygon ("wetland", 5 members)
 - sequence_command: Delete relation multipolygon ("wetland", 5 members)
 - sequence_index: 4
 - sequence_commands: [org.openstreetmap.josm.command.DeleteCommand;org.openstreetmap.josm.command.DeleteCommand;org.openstreetmap.josm.command.DeleteCommand;org.openstreetmap.josm.command.ChangeCommand;org.openstreetmap.josm.command.DeleteCommand]
 - sequence_commands_descriptions: [Delete way ‎699396213‎ (0 nodes)‌;Delete way ‎74590869‎ (0 nodes)‌;Delete way ‎690067609‎ (0 nodes)‌;Change way ‎690067613‎ (251 nodes)‌;Delete relation multipolygon ("wetland", 5 members)]

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Deleted member referenced: {Relation id=1148629 version=11 VT [way 699396213, way 690067613, way 690067607, way 690067609, way 74590869]} (changed by the following commands: )
	at org.openstreetmap.josm.data.osm.Relation.checkMembers(Relation.java:496)
	at org.openstreetmap.josm.data.osm.Relation.fireMembersChanged(Relation.java:508)
	at org.openstreetmap.josm.data.osm.Relation.setMembers(Relation.java:61)
	at org.openstreetmap.josm.data.osm.Relation.load(Relation.java:283)
	at org.openstreetmap.josm.command.DeleteCommand.lambda$undoCommand$1(DeleteCommand.java:233)
	at org.openstreetmap.josm.data.osm.DataSet.update(DataSet.java:1063)
	at org.openstreetmap.josm.command.DeleteCommand.undoCommand(DeleteCommand.java:227)
	at org.openstreetmap.josm.command.SequenceCommand.undoCommands(SequenceCommand.java:138)
	at org.openstreetmap.josm.command.SequenceCommand.undoCommand(SequenceCommand.java:167)
	at org.openstreetmap.josm.data.UndoRedoHandler.lambda$undo$0(UndoRedoHandler.java:381)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWait(GuiHelper.java:225)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:372)
	at org.openstreetmap.josm.data.UndoRedoHandler.undo(UndoRedoHandler.java:362)
	at org.openstreetmap.josm.actions.UndoAction.actionPerformed(UndoAction.java:39)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.desktop/java.awt.Component.processMouseEvent(Unknown Source)
	at java.desktop/javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.Component.processEvent(Unknown Source)
	at java.desktop/java.awt.Container.processEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

[Woazboat]

Duplicate of #23074

[taylor.smock]

In 36132/osm:

Fix some potential DataIntegrityProblemException sources

This also fixes some lint issues.

merge-overlap: See #19627
reltoolbox: See #23074, #23077, #23123

[taylor.smock]

Closed as duplicate of #23074.

[taylor.smock]

In 36133/osm:

Fix some potential DataIntegrityProblemException sources (dist)

This also fixes some lint issues.

merge-overlap: See #19627
reltoolbox: See #23074, #23077, #23123