note not closed after changeset upload

[marc_marc]

What steps will reproduce the problem?

1. select a note and add it to "list of memorised notes"
2. add some osm object
3. upload

What is the expected result?

note should be closed after changeset upload

What happens instead?

sometime notes are still open

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-04-05 13:59:55 +0200 (Wed, 05 Apr 2023)
Build-Date:2023-04-06 01:30:57
Revision:18701
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18701 fr) Linux CentOS Linux release 7.9.2009 (Core)
Memory Usage: 901 MB / 1717 MB (396 MB allocated, but free)
Java version: 1.8.0_362-b08, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr_CH.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME-Classic:GNOME
Java package: java-1.8.0-openjdk:x86_64-1.8.0.362.b08
WebStart package: icedtea-web:x86_64-1.7.1
VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugins:
+ ImproveOsm (238)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector
+ austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
+ cadastre-fr (36021)
+ conflation (0.6.11)
+ continuosDownload (105)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36034)
+ notesolver (0.5.0)
+ opendata (36025)
+ pt_assistant (2.1.15-19-g9aeec3c-SNAPSHOT)
+ reverter (36043)
+ scripting
+ todo (123)
+ utilsplugin2 (36011)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MountainbikeTrails&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/geoimage.at&zip=1
+ https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/Preset_Jungle-Bus.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1
+ https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://raw.github<user.name>content.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1
+ https://raw.github<user.name>content.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://raw.github<user.name>content.com/osmlu/josm-validator-luxembourg/master/Luxembourg-Specific-Rules.validator.mapcss
+ https://raw.github<user.name>content.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- 00029.047 W: Le greffon scripting nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00029.048 W: Le greffon areaselector nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.

[Kmpopppe]

This is a known issue and is tracked ​in this GitHub issue.

Your reproduction steps were "add some OSM object" - is that reproducible the action needed for the Note closure to not work?

Kai

[marc_marc]

unfortunately I haven't yet discovered what the detail is that makes it work sometimes and not sometimes
in the same session, I save a note, add objects and upload, it closes the note and the next time not.
do not hesitate to tell me if some tests or a specific workflow can be useful to understand the issuue

[Kmpopppe]

@marc_marc, please download the ​Pre-Release 0.5.2 to your local plugins-folder (Windows: %APPDATA%\JOSM\plugins).

Please lemme know if this finally solved the problem :)

[marc_marc]

1st test ok, exept the minor detail that the note comment said v0.5.0
as the problem wasn't systematic, I'm going to try and find lots of notes to process to see what happens.

[marc_marc]

1 note memorized, upload with custom comment, the note is style open despite the changeset have the correct closed:note=* tag