duplicate way : sometime with(out) auto-repair

[marc_marc]

What steps will reproduce the problem?

1. load way 1122282039+553715102 215894636+215894636 215895412+695989724
2. run the validator
3. see the diff "duplicate way" <> way at the same position <> all node are duplicate but not the way

What is the expected result?

auto-repair in all case that keep the oldest way OR warn in case of not-duplicate tag (for ex one with building=yes<>building=house)

What happens instead?

the 1st duplicate have an auto-repair (it delete always the new duplicate and keep the old one ?)
the 2nd detect the duplicate way at the same position and doesn't have an auto-repair
the 3nd doesn't detect the duplicate way, it detect duplicates nodes, it detect the duplicate way only if you merge (by hand, no auto-repair) all those duplicate nodes, t

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-14 22:49:24 +0100 (Tue, 14 Mar 2023)
Build-Date:2023-03-15 02:30:57
Revision:18693
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18693 fr) Linux CentOS Linux release 7.9.2009 (Core)
Memory Usage: 593 MB / 1717 MB (136 MB allocated, but free)
Java version: 1.8.0_362-b08, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr_CH
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME-Classic:GNOME
Java package: java-1.8.0-openjdk:x86_64-1.8.0.362.b08
WebStart package: icedtea-web:x86_64-1.7.1
VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugins:
+ ImproveOsm (235)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector
+ austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
+ cadastre-fr (36021)
+ conflation (0.6.11)
+ continuosDownload (105)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36034)
+ opendata (36025)
+ pt_assistant (1ff2e15)
+ reverter (36043)
+ scripting
+ todo (123)
+ utilsplugin2 (36011)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MountainbikeTrails&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/geoimage.at&zip=1
+ https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/Preset_Jungle-Bus.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1
+ https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://raw.github<user.name>content.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1
+ https://raw.github<user.name>content.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://raw.github<user.name>content.com/osmlu/josm-validator-luxembourg/master/Luxembourg-Specific-Rules.validator.mapcss
+ https://raw.github<user.name>content.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- 00017.701 W: Le greffon scripting nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00017.702 W: Le greffon areaselector nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00027.033 E: Impossible de trouver l'image "bus.png"

[skyper]

It is far from simple:

1. Duplicated nodes should only be merged automatically inside the downloaded area. Actually, it works also without any downloaded area which is dangerous.
2. Duplicated ways are ways with identical nodes and tags. Yet again the auto-fix should only be offered if at least one child node is inside the downloaded area. Currently, the auto-fix is offered all the time which is dangerous.
3. Ways at same position are ways identical nodes but differences in tags. Currently, there is no action available in JOSM to merge ways (and create conflicts on tags) so no auto-fix is possible. Even if the action would be available, again, a fix should only be offered if at least one child node is inside the downloaded area.

• The problem without any downloaded area is known, see #19008 and #18414, though I forgot to open an explicit ticket about the issue.
• The duplicated ways rule needs to be changed in order to deny an auto-fix if all child nodes are outside of the downloaded area. New Ticket?

[skyper]

Replying to skyper:

• The problem without any downloaded area is known, see #19008 and #18414, though I forgot to open an explicit ticket about the issue.

See #22847