Modify ↓

Opened 21 months ago

Last modified 21 months ago

#22781 new enhancement

Warning for highway and layer combination

Reported by: adiatmad@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: tag_combination layer highway Cc:

Description

What steps will reproduce the problem?

  1. Add tag layer=* in highway=*
  2. Those tags only, without any additional tag i.e bridge=* or tunnel=*
  3. Press Validation button
  4. For the context, I got this case when checking data from Turkey earthquake mapping(​https://overpass-turbo.eu/s/1rX2)

What is the expected result?

I expected JOSM shows warning for this, because I found this suspicious tag layer=*(​https://www.openstreetmap.org/way/1138493552). Warnings such as "This could be good, but could you double check if this highway requires this layer tag?"

What happens instead?

No warning shows related to this tag combination.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18646
Build-Date:2023-01-30 15:15:00

Identification: JOSM/1.5 (18646 en) Windows 11 64-Bit
OS Build number: Windows 10 Home Single Language 2009 (22621)
Memory Usage: 568 MB / 3908 MB (265 MB allocated, but free)
Java version: 17.0.6+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1200 (scaling 1.25×1.25)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18646, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.1.1)
+ apache-commons (36034)
+ apache-http (35924)
+ auto_tools (81)
+ buildings_tools (36011)
+ changeset-viewer (0.0.6)
+ dataimport (35932)
+ ejml (35924)
+ ext_tools (35893)
+ geotools (36028)
+ gridify (1606242219)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36034)
+ mapathoner (1.3.4-dirty)
+ mapwithai (1.10.4)
+ markseen (14)
+ measurement (35978)
+ merge-overlap (35893)
+ opendata (36025)
+ osm-obj-info (66)
+ reverter (36043)
+ shrinkwrap (v1.0.4)
+ todo (30306)
+ turnrestrictions (36011)
+ undelete (36011)
+ utilsplugin2 (36011)

Tagging presets:
+ %UserProfile%\Downloads\collapsed-buildings.xml
+ %UserProfile%\Desktop\Presets_Emergency-2023-Turkey-preset-preset.xml

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://github.com/osmlab/applepaintstyles/archive/main.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip
- https://github.com/osmlab/applepaintstyles/archive/main.zip
- https://raw.githubusercontent.com/mapbox/mapping/master/JOSM/data-qa.mapcss
- https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://gitlab.com/peculiar-theater/mapcss/-/archive/main/mapcss-main.zip?path=osm-meta
- https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&rule
- https://github.com/MissingMaps/josm_styles/archive/master.zip

Validator rules:
- https://josm.openstreetmap.de/josmfile?page=Rules/AtmsSlovakia&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingStreetnumberOrConscriptionnumber&zip=1
+ https://raw.githubusercontent.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ https://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
- https://raw.githubusercontent.com/zetx16/Josm-HnumbValidator/master/ru-housenumber.validator.mapcss
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
- https://framagit.org/Midgard/osm/-/raw/master/josm_validation_grb.validator.mapcss
- https://josm.openstreetmap.de/josmfile?page=Rules/PublicTransportGtfs&zip=1
+ C:\Users\adiat\AppData\Roaming\JOSM\kaart.indonesiaNames.validator.mapcss

Last errors/warnings:
- 00001.216 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00001.220 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.978 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00014.592 E: java.nio.file.NoSuchFileException: %UserProfile%\Desktop\Presets_Emergency-2023-Turkey-preset-preset.xml
- 00014.593 E: %UserProfile%\Desktop\Presets_Emergency-2023-Turkey-preset-preset.xml
- 00015.531 W: Failed to add C:\Users\adiat\AppData\Roaming\JOSM\kaart.indonesiaNames.validator.mapcss to tag checker
- 00015.532 W: java.nio.file.NoSuchFileException: C:\Users\adiat\AppData\Roaming\JOSM\kaart.indonesiaNames.validator.mapcss
- 00023.166 E: Failed to locate image 'MapWithAI'

Attachments (0)

Change History (1)

comment:1 by skyper, 21 months ago

Keywords: layer highway added

Once again, tagging to silence QA.
This would be covered by #9304.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to adiatmad@….
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.