[patch][github PR] Cattle Grid gives strange warming

[josm@…]

What steps will reproduce the problem?

1. Load a way which includes a cattle grid, or add a cattle grid.

What is the expected result?

Saves with no warning

What happens instead?

Warns that it is missing access tags

Please provide any additional information below. Attach a screenshot if possible.

There are no legal restrictions on who or what can cross a cattle grid which are different from that of the way crossing it.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-01-29 21:53:34 +0100 (Sun, 29 Jan 2023)
Revision:18646
Build-Date:2023-01-30 02:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18646 en_GB) Linux Fedora Linux 37 (Workstation Edition)
Memory Usage: 1084 MB / 3970 MB (306 MB allocated, but free)
Java version: 17.0.6+10, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_GB.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME
Java package: java-17-openjdk:x86_64-17.0.6.0.10
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (35951)
+ Mapillary (2.1.1)
+ OpeningHoursEditor (35924)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36011)
+ ejml (35924)
+ geochat (35978)
+ geotools (36028)
+ graphview (36011)
+ gson (35924)
+ http2 (35921)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jogl (1.2.3)
+ jts (36004)
+ log4j (36034)
+ measurement (35978)
+ opendata (36025)
+ public_transport (36011)
+ reverter (36043)
+ routing (35978)
+ tageditor (36011)
+ terracer (35978)
+ turnlanes (36011)
+ turnlanes-tagging (v0.0.5)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)
+ wikipedia (605)

Last errors/warnings:
- 02966.676 W: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.net.SocketException: Connection reset
- 02966.705 W: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.net.SocketException: Connection reset
- 02966.705 W: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.net.SocketException: Connection reset
- 02966.813 W: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.net.SocketException: Connection reset
- 02966.814 W: Already here java.net.SocketException: Connection reset
- 02966.817 W: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.io.IOException: HTTP/1.1 header parser received no bytes. Cause: java.net.SocketException: Connection reset
- 02966.817 W: Already here java.net.SocketException: Connection reset
- 03007.157 W: restricted header name: "Connection"
- 03007.368 W: restricted header name: "Connection"
- 03007.766 W: restricted header name: "Connection"

[Klumbumbus]

Cannot reproduce this in core. I assume this comes from a plugin. Could you please hover over the warning in the validator panel and write the displayed text here or add a screenshot of this popup?

[pch14@…]

Got that just now too. Text in popup says:

verdächtige Barriere - barrier=cattle_grid ohne Zugangsattribut wie etwa access, motor_vehicle oder vehicle. (2)
Test: Merkmalsprüfer (basierend auf MapCSS) Merkmalskombinationen

Should I tag: cows=no ;)

[Famlam]

@Klumbumbus
I suspect barrier=cattle_grid should be added to the list of exceptions in line 123 here:
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L122

way[highway=~/^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link)$/][!access][!vehicle] > node[barrier][barrier!~/entrance|border_control|height_restrictor|toll_booth/][!access][!motor_vehicle][!vehicle] {
->
way[highway=~/^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link)$/][!access][!vehicle] > node[barrier][barrier!~/entrance|border_control|cattle_grid|height_restrictor|toll_booth/][!access][!motor_vehicle][!vehicle] {

[pch14@…]

The warning triggers on a secondary, eg. ​https://www.openstreetmap.org/way/224356944, but not on a residential, eg. ​https://www.openstreetmap.org/way/224358654

[anonymous]

That sounds an odd rule.

Cattle grids can exist on any category of road

They certainly exist on trunk.

[Phil <josm@…>]

Re cows=no.

They are more associated with sheep I my experience

[Famlam]

Patch @ ​https://github.com/JOSM/josm/pull/121

[Klumbumbus]

In 18734/josm:

fix #22739 - Don't warn about missing access tags on barrier=cattle_grid nodes also in major roads (tertiary_link and above)(patch by Famlam)