"Unkown value" does not properly handle white space

[Rainero]

What steps will reproduce the problem?

1. download an area, where an object exists that has set the tag quality=incomplete, e.g. at Karlsruhe Hbf in Germany. There is a master_route relation which has this tag: ​https://www.openstreetmap.org/relation/5515483
2. Run the JOSM validator
3. Look for Unknown value (Unbekannter Wert in my german setting). It will show: Value 'incomplete' is unknown for key 'quality', may be ' incomplete' is meant?

What is the expected result?

No warning from validator is expected.

What happens instead?

the validator shows a warning, because it expects ' incomplete' with a leading space character.
This is probably a typo in the validator rule.

Please provide any additional information below. Attach a screenshot if possible.

Screenshot is attached.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-01-29 21:53:34 +0100 (Sun, 29 Jan 2023)
Revision:18646
Build-Date:2023-01-30 02:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18646 de) Linux openSUSE Leap 15.3
Memory Usage: 1737 MB / 3970 MB (516 MB allocated, but free)
Java version: 11.0.17+0-suse-150000.3.86.2-x8664, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: de_DE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
Java package: java-11-openjdk:x86_64-11.0.17.0
apache-commons-compress: apache-commons-compress:noarch-1.21
apache-commons-logging: apache-commons-logging:noarch-1.2
Dataset consistency test: No problems found

Plugins:
+ CADTools (1008)
+ MakeParallel (v1.1.0)
+ PolygonCutOut (v0.7.1)
+ buildings_tools (36011)
+ centernode (v1.0.4)
+ contourmerge (v0.1.9)
+ editgpx (35931)
+ reverter (36043)
+ tageditor (36011)
+ terracer (35978)
+ turnlanes (36011)
+ turnlanes-tagging (v0.0.5)
+ utilsplugin2 (36011)

Tagging presets:
+ https://raw.githubusercontent.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Fahrradverleih&zip=1
+ https://www.openrailwaymap.org/josm-presets/de.zip
+ https://www.openrailwaymap.org/josm-presets/de-signals-eso.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/OpenStationMap&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportGtfs&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Radwege&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/hiking_routes_with_trail_marking&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1
- https://www.openrailwaymap.org/styles/maxspeed.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
+ https://www.openrailwaymap.org/styles/signals.zip
- https://www.openrailwaymap.org/styles/standard.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1

Last errors/warnings:
- 00008.684 E: Defekte Taggingvorlage "bicycle_rental-Concretization for rental bikes" - Anzahl der Elemente in 'display_values' muss gleich sein wie in 'values'.
- 00008.684 E: Detaillierte Information: [Lastenräder, eBikes, Fahrradanhänger] <> [cargo_bike, e-bikes, bike_trailer, yes]
- 00008.699 E: Defekte Taggingvorlage "public_transport-Public transport?" - Anzahl der Elemente in 'display_values' muss gleich sein wie in 'values'.
- 00008.700 E: Detaillierte Information: [yes, no] <> [station]
- 00008.700 E: Defekte Taggingvorlage "public_transport-Public transport?" - Anzahl der Elemente in 'locale_display_values' muss gleich sein wie in 'values'.
- 00008.700 E: Detaillierte Information: [ja, nein] <> [station]
- 32820.053 W: Konflikte gefunden - <html>5 Konflikte wurden entdeckt.</html>

[skyper]

This is caused by the external preset PublicTransportGtfs. JOSM does not like the change of delimiter, e.g. delimiter=", ".

[Klumbumbus]

Replying to skyper:

This is caused by the external preset PublicTransportGtfs. JOSM does not like the change of delimiter, e.g. delimiter=", ".

Is there any reason not to change this line to the default delimiter semicolon?

[skyper]

Well, values for quality=* showed a different use with comma and an empty space when I wrote the preset. Looking at current numbers I do not find many semicolon but lots of commas even some with values not part of the preset.

Changing the preset will not fix the problem in the validator code. I wonder if the empty space is a problem or the use of delimiter in general.

[Klumbumbus]

Ah, I overlooked, that it is a multiselect and not a combo and thus has effect on the actual value.
Anyway, quality=complete, ordered is used only in one area around Freiburg im Breisgau. All other values of quality we can pretty much forget completely due to low numbers. Considering there is no wiki page for quality I would rather suggest to remove this preset line completely.

[skyper]

Yes, I can remove the line but that will not help to solve the problem in validator and will not update the documentation how to properly use delimiter in presets. Is the empty space a problem?

[skyper]

How about simply ignoring white spaces in front and after the value?