Modify

#22726 closed defect (fixed)

[PATCH] DownloadOsmChange task should not always get the history for each unknown object

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 23.04
Component: Core Version:
Keywords: Cc:

Description

When downloading an OSC, especially if the OSC primarily deals with ways, a user may wait an extended period of time for the Node objects to be downloaded. This is often not necessary, since many nodes don't change frequently, if at all.

With the attached patch, the timings for https://maproulette.org/api/v2/task/147247105/cooperative/change/task_147247105_change.osc for went from 105s to 14s, assuming no user interaction.

Attachments (1)

22726.patch (8.9 KB ) - added by taylor.smock 23 months ago.

Download all attachments as: .zip

Change History (3)

by taylor.smock, 23 months ago

Attachment: 22726.patch added

comment:1 by taylor.smock, 21 months ago

Milestone: 23.0323.04

Ticket retargeted after milestone closed

comment:2 by taylor.smock, 21 months ago

Resolution: fixed
Status: newclosed

In 18711/josm:

Fix #22726: DownloadOsmChange task should not always get the history for each unknown object

In many cases, the latest version of an object will also be the version we will
get when iterating through all of its history. This will always be the case for
objects with only one version. As such, in most cases, getting the latest version
of an object will significantly reduce the number of individual history calls.

In a test, the amount of time taken to load an OSC went from 105 seconds to 14
seconds. This is an 86% improvement in terms of time taken.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.