MapRoulette plugin generates upload tags that are too long when completing multiple tasks together

[watmildon]

What steps will reproduce the problem?

1. Download this BBOX 47.6726701;-122.1179724;47.6891392;-122.0905924
2. Get MR tasks for the area
3. Use this search to select the nodes needing cleanup: "type:node building inview"
4. Hit upload
5. Hit "Yes and ignore for this session"
6. Add comment, hit upload

What is the expected result?

Changes are uploaded

What happens instead?

Exception from the plugin adding info about all nodes changed into an upload tag

Please provide any additional information below. Attach a screenshot if possible.

Revision:18646
Build-Date:2023-01-30 15:15:00

Identification: JOSM/1.5 (18646 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19045)
Memory Usage: 468 MB / 4088 MB (248 MB allocated, but free)
Java version: 17.0.6+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1440×2560 (scaling 1.00×1.00) \Display1 3840×2160 (scaling 1.50×1.50)
Maximum Screen Size: 3840×2560
Best cursor sizes: 16×16→48×48, 32×32→48×48
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18646, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35978)
+ FixAddresses (36011)
+ MapRoulette (1675695329)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36011)
+ conflation (0.6.9)
+ continuosDownload (105)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ gridify (1606242219)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ mapwithai (1.10.4)
+ opendata (36025)
+ reverter (36043)
+ tageditor (36011)
+ terracer (35978)
+ todo (30306)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)
+ wikipedia (605)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/TigerReviewedNo&zip=1
- %UserProfile%\Address Tags Validator - Highlight unaddressed
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 00000.482 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.484 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.777 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00017.663 E: Failed to locate image 'MapWithAI'
- 00976.185 E: Handled by bug report queue: java.lang.IllegalArgumentException: Changeset tag value is too long: 145072647;145072741;145074854;145076088;145078293;145079449;145081378;145089834;145091328;145092058;145094218;145095264;145097266;145097276;145099953;145102209;145102483;145104190;145107522;145107605;145108035;145109943;145111665;145114074;145115729;145116997;145117704;145117934;145119675;145121186;145130747;145131898;145132382;145134560;145135925;145136106;145136142;145139524;145140226;145144489;145147351;145147766;145149946;145150122;145152321;145157355;145158984;145160938;145161146;145169547;145170806;145173529;145174761;145176472;145177429;145177736;145178095;145185267;145186754;145187281;145187598;145187730;145188227;145196629;145196736;145197224;145201469;145205832



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
java.lang.IllegalArgumentException: Changeset tag value is too long: 145072647;145072741;145074854;145076088;145078293;145079449;145081378;145089834;145091328;145092058;145094218;145095264;145097266;145097276;145099953;145102209;145102483;145104190;145107522;145107605;145108035;145109943;145111665;145114074;145115729;145116997;145117704;145117934;145119675;145121186;145130747;145131898;145132382;145134560;145135925;145136106;145136142;145139524;145140226;145144489;145147351;145147766;145149946;145150122;145152321;145157355;145158984;145160938;145161146;145169547;145170806;145173529;145174761;145176472;145177429;145177736;145178095;145185267;145186754;145187281;145187598;145187730;145188227;145196629;145196736;145197224;145201469;145205832
	at org.openstreetmap.josm.data.osm.Changeset.lambda$setKeys$1(Changeset.java:318)
	at java.base/java.util.Optional.ifPresent(Unknown Source)
	at org.openstreetmap.josm.data.osm.Changeset.setKeys(Changeset.java:317)
	at org.openstreetmap.josm.gui.io.UploadDialog.getChangeset(UploadDialog.java:318)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:270)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:303)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.desktop/java.awt.Component.processMouseEvent(Unknown Source)
	at java.desktop/javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.Component.processEvent(Unknown Source)
	at java.desktop/java.awt.Container.processEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

[taylor.smock]

java.lang.IllegalArgumentException: Changeset tag value is too long: 145072647;145072741;145074854;145076088;145078293;145079449;145081378;145089834;145091328;145092058;145094218;145095264;145097266;145097276;145099953;145102209;145102483;145104190;145107522;145107605;145108035;145109943;145111665;145114074;145115729;145116997;145117704;145117934;145119675;145121186;145130747;145131898;145132382;145134560;145135925;145136106;145136142;145139524;145140226;145144489;145147351;145147766;145149946;145150122;145152321;145157355;145158984;145160938;145161146;145169547;145170806;145173529;145174761;145176472;145177429;145177736;145178095;145185267;145186754;145187281;145187598;145187730;145188227;145196629;145196736;145197224;145201469;145205832

It looks like I need to split the tag into multiple tags, if necessary. I'm going to have to think about how to do that.