{apikey} fails for Swedish historic orthophoto endpoint imagery

[nkamapper]

What steps will reproduce the problem?

Pan over Sweden and select the Historic Orthophoto endpoint imagery.

What is the expected result?

Imagery opens with {apikey}

What happens instead?

Pop-up window asking for authentication information appears.

Please provide any additional information below. Attach a screenshot if possible.

Link to imagery: https://josm.openstreetmap.de/wiki/Maps/Sweden#LantmterietHistoricOrthophotosoptions
{apikey} was recently introduced for imagery by stoecker. Perhaps does not work for endpoint?

Revision:18622
Build-Date:2023-01-04 13:00:15

Identification: JOSM/1.5 (18622 en_GB) Mac OS X 12.6.1
OS Build number: macOS 12.6.1 (21G217)
Memory Usage: 900 MB / 4096 MB (210 MB allocated, but free)
Java version: 17.0.5+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69733568 1440×900 (scaling 2.00×2.00)
Maximum Screen Size: 1440×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=18622, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=/Applications/JOSM.app/Contents/MacOS/JOSM]

Plugins:
+ PicLayer (1.0.2)
+ apache-commons (36034)
+ apache-http (35924)
+ changeset-viewer (0.0.6)
+ conflation (0.6.9)
+ ejml (35924)
+ ext_tools (35893)
+ geotools (36028)
+ imagery-xml-bounds (35976)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36034)
+ opendata (36025)
+ pdfimport (35976)
+ reverter (36043)
+ todo (30306)
+ utilsplugin2 (36011)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 00085.203 E: Could not parse WMS layer list. Incoming data:
- 00086.702 E: Failed to locate image 'https://www.lfv.se/globalassets/om-lfv/logo-orange.png'
- 00086.825 E: Failed to locate image 'https://pbs.twimg.com/profile_images/1311935759038009344/u7KwPme-_200x200.jpg'
- 00107.083 E: Failed to locate image 'https://www.lfv.se/globalassets/om-lfv/logo-orange.png'
- 00107.204 E: Failed to locate image 'https://pbs.twimg.com/profile_images/1311935759038009344/u7KwPme-_200x200.jpg'
- 00282.492 E: Failed to locate image 'https://www.lfv.se/globalassets/om-lfv/logo-orange.png'
- 00282.614 E: Failed to locate image 'https://pbs.twimg.com/profile_images/1311935759038009344/u7KwPme-_200x200.jpg'
- 00303.430 E: Could not parse WMS layer list. Incoming data:
- 00306.573 E: Failed to locate image 'https://www.lfv.se/globalassets/om-lfv/logo-orange.png'
- 00306.690 E: Failed to locate image 'https://pbs.twimg.com/profile_images/1311935759038009344/u7KwPme-_200x200.jpg'

[taylor.smock]

This is a JOSM bug. It looks like we aren't replacing the {apikey} prior to asking for layers, which leads to the error.

[taylor.smock]

In 18628/josm:

Fix #22642: {apikey} fails for Swedish historic orthophoto endpoint imagery

This occurred since we were not replacing the {apikey} for endpoints.