Modify ↓

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#22622 closed defect (worksforme)

Apply button in the "Edit relation" dialog

Reported by: angoca Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. When editing a relation, like a boundary, it does not refresh the Tags panel, until it is accepted.
  2. However, when the relation has to be modified for other segments, one have to reopen the dialog. And sometimes, several relations are modified, when adjusting boundaries.

What is the expected result?

To have an Apply button in the Edit Relation, that will "save" the changes, update the panels, and leave the panel open.

What happens instead?

One has to open an close the dialogs several times when editing large relations.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-12-28 19:38:17 +0100 (Wed, 28 Dec 2022)
Build-Date:2022-12-29 02:30:57
Revision:18621
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18621 en) Mac OS X 10.15.7
OS Build number: Mac OS X 10.15.7 (19H2026)
Memory Usage: 987 MB / 3641 MB (133 MB allocated, but free)
Java version: 1.8.0_351-b10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 731408969 1920×1080 (scaling 1.00×1.00) Display 69731270 1440×900 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_CO
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-400bc4f6, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-7a1c6b48.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35978)
+ Mapillary (2.1.1)
+ apache-commons (36034)
+ apache-http (35924)
+ buildings_tools (36011)
+ continuosDownload (105)
+ damn (0.9.0)
+ ejml (35924)
+ geotools (36028)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ mapwithai (v1.10.0)
+ notesolver (0.4.2)
+ opendata (36025)
+ reverter (36043)
+ utilsplugin2 (36011)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/SITP-Transmilenio&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Validator rules:
+ https://raw.githubusercontent.com/MaptimeBogota/ColombianJosmValidator/main/Rules_Colombian-specific.validator.mapcss

Last errors/warnings:
- 10271.870 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 10271.879 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 10271.902 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 10271.945 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 11279.425 W: Conflict in data - <html>This relation has been changed outside of the editor.<br>You cannot apply your changes and continue editing.<br><br>Do you want to create a conflict and close the editor?</html>
- 17484.796 W: Skip smooth scrolling
- 17605.312 W: Skip smooth scrolling
- 17605.812 W: Skip smooth scrolling
- 19742.569 W: Skip smooth scrolling
- 19742.691 W: Skip smooth scrolling

Attachments (0)

Change History (2)

in reply to:  description comment:1 by Klumbumbus, 2 years ago

Resolution: → worksforme
Status: new → closed

Replying to angoca:

What is the expected result?

To have an Apply button in the Edit Relation, that will "save" the changes, update the panels, and leave the panel open.

There is a save/apply button at the top of the relation editor window which does exactly this.
See also the section "So the workflow should always be like this..." at wiki:/Help/Dialog/RelationEditor#RelationChangedOutsideOfEditor

comment:2 by Klumbumbus, 2 years ago

Summary: Apply button in the "Edit relation" dialot → Apply button in the "Edit relation" dialog

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.