A single click can touch multiple geoimage layers

[Adrian]

What steps will reproduce the problem?

1. Launch JOSM or delete all layers if JOSM is already running.
2. Load the attached .joz (session) file.
3. Consult the attached screenshot, zoom out to the scale shown, and click as near as you can to the position shown. (See the latitude and longitude in the JOSM status bar.)

What is the expected result?

One image is selected. Because there is only one tab, the tab is hidden in the image viewer window.

What happens instead?

One image is selected in bright red and two in dark red. Three tabs appear at once in the image viewer window.

Please provide any additional information below. Attach a screenshot if possible.

I suspect that this issue existed before the tab feature was added. But you could not see it because only one image could be selected. Now that multiple images can be selected, you see the issue.

Revision:18621
Is-Local-Build:true
Build-Date:2022-12-28 19:40:56

Identification: JOSM/1.5 (18621 SVN en_GB) Mac OS X 11.7.2
OS Build number: macOS 11.7.2 (20G1020)
Memory Usage: 404 MB / 4096 MB (172 MB allocated, but free)
Java version: 18.0.2.1+1, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 1007312129 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_GB.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ ImportImagePlugin (36013)
+ InfoMode (35978)
+ PicLayer (1.0.2)
+ apache-commons (36003)
+ cadastre-fr (36021)
+ editgpx (35931)
+ ejml (35924)
+ geotools (36028)
+ http2 (35921)
+ imagery_offset_db (35978)
+ jackson (36006)
+ jaxb (35952)
+ jts (36004)
+ log4j (36007)
+ measurement (35978)
+ opendata (36025)
+ photo_geotagging (35933)
+ poly (35976)
+ reverter (36011)
+ turnrestrictions (36011)
+ undelete (36011)
+ utilsplugin2 (36011)
+ waydownloader (36011)

Last errors/warnings:
- 00004.527 W: Update plug-ins - You updated your JOSM software. To prevent problems the plug-ins should be updated as well.  Update plug-ins now?
- 00061.596 E: java.io.FileNotFoundException: /Volumes/128GB 1/20180923/R0041563.JPG (No such file or directory)
- 00061.606 E: java.io.FileNotFoundException: /Volumes/128GB 1/20180925/R0044509.JPG (No such file or directory)
- 00061.615 E: java.io.FileNotFoundException: /Volumes/128GB 1/20180926/R0046899.JPG (No such file or directory)

[Adrian]

Session file

[Adrian]

Screenshot - touch three layers with one click

[taylor.smock]

I suspect that this issue existed before the tab feature was added. But you could not see it because only one image could be selected. Now that multiple images can be selected, you see the issue.

Quite probably -- I suspect it was previously "last one wins". I think we are using proximity to the click in order to select images.

How should this be handled? How do we know which image the user actually intended to click? Once the user zooms out to the point where they could have conceivably clicked multiple different images, what should we do?

I think the current handling is about as good as we can do, without a lot of work.

[Adrian]

Replying to taylor.smock:

How should this be handled? How do we know which image the user actually intended to click? Once the user zooms out to the point where they could have conceivably clicked multiple different images, what should we do?

Ideally only one image would be selected. When the image icons overlap, clicking on an icon is a bit hit-and-miss. So I think it is not very important, which image gets selected. Maybe you could take the one in the highest layer that was touched, because those icons will be on top. Or maybe you could do "first one wins" if you can arrange for the layers to consume the mouse event.

A bit off-topic, but in the wiki I have documented the advanced preference for setting the highlight colour (default dark red). The tab feature and the integration with Mapillary now need to be documented in the wiki.