No indication of and no option to delete automatically added CS-tag "hashtag"

[skyper]

What steps will reproduce the problem?

1. Upload some data
2. In the upload dialog add something like repair routes #403303 and #2114080

What is the expected result?

An indication that hashtag=#403303;#2114080 is added as additional CS-tag plus an option to delete this tag

What happens instead?

No indication and the tag is always added again despite manually deleting it.

Please provide any additional information below. Attach a screenshot if possible.

See ​osmwww:changeset/130575508 as example.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-12-27 16:51:43 +0100 (Tue, 27 Dec 2022)
Revision:18619
Build-Date:2022-12-28 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18619 en) Linux Debian GNU/Linux 11 (bullseye)
Memory Usage: 180 MB / 256 MB (57 MB allocated, but free)
Java version: 17.0.4+8-Debian-1deb11u1, Debian, OpenJDK 64-Bit Server VM

VM arguments: [-Djosm.home=<josm.pref>]
Dataset consistency test: No problems found

[taylor.smock]

It looks like the behavior is controlled by the advanced preference upload.changeset.hashtags.

Anyway, sample patch:

src/org/openstreetmap/josm/gui/io/UploadDialogModel.java

@@ -5 +5 @@
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -27 +29 @@
     public static final String COMMENT = "comment";
     /** the "source" changeset OSM key */
     public static final String SOURCE = "source";
+    /** The "hashtag" changeset OSM key */
+    private static final String HASHTAGS = "hashtags";
     /** the user-agent */
     private final String agent = Version.getInstance().getAgentString(false);
     /** whether to extract hashtags from comment */
-    private final boolean hashtags = Config.getPref().getBoolean("upload.changeset.hashtags", true);
+    private boolean hashtags = Config.getPref().getBoolean("upload.changeset.hashtags", true);
 
     /** a lock to prevent loops  */
     private boolean locked;
@@ -42 +46 @@
                 locked = true;
                 // add "hashtags" if any
                 if (hashtags) {
-                    put("hashtags", findHashTags(getValue(COMMENT)));
+                    final String hashTags = findHashTags(getValue(COMMENT));
+                    Optional<TagModel> hashTagModel = tags.stream().filter(tm -> HASHTAGS.equals(tm.getName())).findFirst();
+                    if ((hashTagModel.isPresent() && !hashTagModel.get().hasValue(hashTags))
+                            || (!hashTagModel.isPresent() && !Utils.isBlank(hashTags))) {
+                        put(HASHTAGS, hashTags);
+                        UploadDialog.getUploadDialog().setChangesetTagsModifiedProgramatically();
+                    }
                 }
                 // add/update "created_by"
                 final String createdBy = getValue(CREATED_BY);
@@ -106 +116 @@
         return result.toString();
     }
 
+    @Override
+    public void deleteTagNames(int... tagIndices) {
+        handleTagModelDeletion(getTagModels(tagIndices));
+        super.deleteTagNames(tagIndices);
+    }
+
+    @Override
+    public void deleteTagValues(int... tagIndices) {
+        handleTagModelDeletion(getTagModels(tagIndices));
+        super.deleteTagValues(tagIndices);
+    }
+
+    @Override
+    public void delete(String name) {
+        if (HASHTAGS.equals(name)) {
+            this.hashtags = false;
+        }
+        super.delete(name);
+    }
+
+    @Override
+    public void deleteTags(int... tagIndices) {
+        handleTagModelDeletion(getTagModels(tagIndices));
+        super.deleteTags(tagIndices);
+    }
+
+    private TagModel[] getTagModels(int... tagIndices) {
+        return Arrays.stream(tagIndices).mapToObj(tags::get).filter(Objects::nonNull).toArray(TagModel[]::new);
+    }
+
+    private void handleTagModelDeletion(TagModel[] tagModels) {
+        for (TagModel tagModel : tagModels) {
+            if (HASHTAGS.equals(tagModel.getName())) {
+                this.hashtags = false;
+            }
+        }
+    }
+
     /**
      * Inserts/updates/deletes a tag.
      *

Really, we should probably update TagEditorModel to fire the appropriate deletion/addition events, possibly subclassing the TableModelChanged event so that we can pass a list of the models changed, instead of just a generic table changed event.

[skyper]

Replying to taylor.smock:

It looks like the behavior is controlled by the advanced preference upload.changeset.hashtags.

Thanks, this should be documented but wiki:Help/Action/Upload is already huge, partly outdated and messy. E.g. it needs quite some rework.