Modify

Opened 19 months ago

Closed 13 months ago

Last modified 13 months ago

#22569 closed enhancement (fixed)

[Patch] Add beauty multiselect key to shop=beauty preset

Reported by: jose1711 Owned by: team
Priority: normal Milestone: 23.06
Component: Internal preset Version:
Keywords: shop beauty Cc:

Description

shop=beauty is often combined with beauty=* showing the list of provided services. This adds the most frequent values (as per wiki and taginfo) to JOSM.

Attachments (2)

beauty_values.patch.gz (186 bytes ) - added by jose1711 19 months ago.
Patch (defaultpresets.xml)
beauty_values.patch (1.8 KB ) - added by jose1711 19 months ago.
Patch - version 2

Download all attachments as: .zip

Change History (8)

by jose1711, 19 months ago

Attachment: beauty_values.patch.gz added

Patch (defaultpresets.xml)

comment:1 by skyper, 19 months ago

Component: CoreInternal preset
Keywords: shop beauty added

Patch suggest to add:

<multiselect key="beauty" text="Beauty services" values="nails;tanning;cosmetics;spa;skin_care;waxing;hair_removal;eyebrow;aestetic;massage;eyelash" values_searchable="true" />

aestetic is a typo and should be aesthetic but numbers are quite low, ~250 counting all.
A preset link between shop=beauty and shop=massage plus shop=beauty and shop=hairdresser would be useful.

Last edited 19 months ago by skyper (previous) (diff)

in reply to:  1 comment:2 by jose1711, 19 months ago

Replying to skyper:

Patch suggest to add:

<multiselect key="beauty" text="Beauty services" values="nails;tanning;cosmetics;spa;skin_care;waxing;hair_removal;eyebrow;aestetic;massage;eyelash" values_searchable="true" />

aestetic is a typo and should be aesthetic but numbers are quite low, ~250 counting all.
A preset link between shop=beauty and shop=massage plus shop=beauty and shop=hairdresser would be useful.

Thank you for your review. Adding updated relevant part in full:

<item name="Beauty" icon="presets/shop/beauty.svg" type="node,closedway,multipolygon" preset_name_label="true">
            <link wiki="Tag:shop=beauty" />
            <space />
            <key key="shop" value="beauty" />
            <multiselect key="beauty" text="Beauty services" values="nails;tanning;cosmetics;spa;skin_care;waxing;hair_removal;eyebrow;massage;eyelash" values_searchable="true" />
            <reference ref="name_oh_wheelchair" />
            <reference ref="link_contact_address_payment" /> 
            <preset_link preset_name="Massage" text="Similar but different tags:" />
            <preset_link preset_name="Hairdresser/Barber" text="Similar but different tags:" />
</item> <!-- Beauty -->

comment:3 by skyper, 19 months ago

Thanks for the update. To be consistent we should add preset link from shop=massage and shop=hairdresser to shop=beauty.
For proper patches we need the diff, see DevelopersGuide/PatchGuide.

by jose1711, 19 months ago

Attachment: beauty_values.patch added

Patch - version 2

comment:4 by skyper, 19 months ago

Summary: Add beauty multiselect key to shop=beauty preset[Patch] Add beauty multiselect key to shop=beauty preset

comment:5 by taylor.smock, 13 months ago

Resolution: fixed
Status: newclosed

In 18769/josm:

Fix #22569: Add beauty multiselect key to shop=beauty preset (patch by jose1711)

comment:6 by taylor.smock, 13 months ago

Milestone: 23.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.