#22569 closed enhancement (fixed)
[Patch] Add beauty multiselect key to shop=beauty preset
Reported by: | jose1711 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 23.06 |
Component: | Internal preset | Version: | |
Keywords: | shop beauty | Cc: |
Description
shop=beauty is often combined with beauty=* showing the list of provided services. This adds the most frequent values (as per wiki and taginfo) to JOSM.
Attachments (2)
Change History (8)
by , 19 months ago
Attachment: | beauty_values.patch.gz added |
---|
follow-up: 2 comment:1 by , 19 months ago
Component: | Core → Internal preset |
---|---|
Keywords: | shop beauty added |
Patch suggest to add:
<multiselect key="beauty" text="Beauty services" values="nails;tanning;cosmetics;spa;skin_care;waxing;hair_removal;eyebrow;aestetic;massage;eyelash" values_searchable="true" />
aestetic
is a typo and should be aesthetic
but numbers are quite low, ~250 counting all.
A preset link between shop=beauty
and shop=massage
plus shop=beauty
and shop=hairdresser
would be useful.
comment:2 by , 19 months ago
Replying to skyper:
Patch suggest to add:
<multiselect key="beauty" text="Beauty services" values="nails;tanning;cosmetics;spa;skin_care;waxing;hair_removal;eyebrow;aestetic;massage;eyelash" values_searchable="true" />
aestetic
is a typo and should beaesthetic
but numbers are quite low, ~250 counting all.
A preset link betweenshop=beauty
andshop=massage
plusshop=beauty
andshop=hairdresser
would be useful.
Thank you for your review. Adding updated relevant part in full:
<item name="Beauty" icon="presets/shop/beauty.svg" type="node,closedway,multipolygon" preset_name_label="true"> <link wiki="Tag:shop=beauty" /> <space /> <key key="shop" value="beauty" /> <multiselect key="beauty" text="Beauty services" values="nails;tanning;cosmetics;spa;skin_care;waxing;hair_removal;eyebrow;massage;eyelash" values_searchable="true" /> <reference ref="name_oh_wheelchair" /> <reference ref="link_contact_address_payment" /> <preset_link preset_name="Massage" text="Similar but different tags:" /> <preset_link preset_name="Hairdresser/Barber" text="Similar but different tags:" /> </item> <!-- Beauty -->
comment:3 by , 19 months ago
Thanks for the update. To be consistent we should add preset link from shop=massage
and shop=hairdresser
to shop=beauty
.
For proper patches we need the diff, see DevelopersGuide/PatchGuide.
comment:4 by , 19 months ago
Summary: | Add beauty multiselect key to shop=beauty preset → [Patch] Add beauty multiselect key to shop=beauty preset |
---|
comment:6 by , 13 months ago
Milestone: | → 23.06 |
---|
Patch (defaultpresets.xml)