Modify

Opened 2 years ago

Closed 2 years ago

#22552 closed enhancement (worksforme)

Validation of highway class names not perfect

Reported by: MSiipola Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report highway values TagChecker Cc:

Description

What steps will reproduce the problem?

  1. Create a highway with tag "highway=un"
  2. Validate the highway
  3. No warning

But "highway=unclassfiedx" will generate a warning.
The first example should also create a warning.

Revision:18583
Build-Date:2022-11-01 14:35:40

Identification: JOSM/1.5 (18583 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 948 MB / 4078 MB (462 MB allocated, but free)
Java version: 17.0.5+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 2560×1440 (scaling 1.00×1.00)
Maximum Screen Size: 2560×1440
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_SE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18583, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Program arguments: [%UserProfile%\Documents\OSM\start.jos]
Dataset consistency test: No problems found

Plugins:
+ MakeParallel (v1.1.0)
+ PicLayer (1.0.2)
+ apache-commons (36034)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ log4j (36034)
+ measurement (35978)
+ merge-overlap (35893)
+ opendata (36025)
+ reltoolbox (35976)
+ reverter (36011)
+ turnlanes (36011)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 00000.284 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.285 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.827 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
- 00009.628 W: Unable to find supported projection for layer Lantmäteriet ORTO. Using EPSG:3857.
- 00009.630 W: Unable to find supported projection for layer Lantmäteriet ORTO. Using EPSG:3857.

Attachments (0)

Change History (3)

comment:1 by skyper, 2 years ago

Component: CoreCore validator
Keywords: highway values TagChecker added
Type: defectenhancement

Ok, for highway=unclassfiedx I get a warning Unknown property value - Value 'unclassfiedx' for key 'highway' is unknown, maybe 'unclassified' is meant? as the value is close to unclassified.
For highway=un, I get an informal warning Presets do not contain property value - Value 'un' for key 'highway' not in presets. but informal warnings have to be enabled manually.

I do not think that we can do anything else as new values are possible and presets might not include all valid values.

comment:2 by MSiipola, 2 years ago

Ok, about enabling informal warnings.

comment:3 by skyper, 2 years ago

Resolution: worksforme
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.