Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#22445 closed defect (fixed)

Icon for Wikimedia Commons on Layer List Panel help page is too big

Reported by: stoffld Owned by: team
Priority: normal Milestone: 22.10
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Klick the help icon on the Layer List Panel

What is the expected result?

The icons on the section "Layer types" should all be the same size.

What happens instead?

The icon for Wikimedia Commons is way too big.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-10-06 21:10:57 +0200 (Thu, 06 Oct 2022)
Revision:18570
Build-Date:2022-10-07 01:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18570 de) Linux Mint 21
Memory Usage: 1362 MB / 3916 MB (284 MB allocated, but free)
Java version: 11.0.16+8-post-Ubuntu-0ubuntu122.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: de_DE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: X-Cinnamon
Java package: openjdk-11-jre:amd64-11.0.16+8-0ubuntu1~22.04
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20201225-1build1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ ImproveWay (32)
+ OpeningHoursEditor (35924)
+ PicLayer (1.0.2)
+ buildings_tools (36011)
+ changeset-viewer (v0.0.6)
+ contourmerge (v0.1.9)
+ imagery_offset_db (35978)
+ measurement (35978)
+ reltoolbox (35976)
+ utilsplugin2 (36011)

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/DE.zip

Last errors/warnings:
- 00005.348 E: Old Id 'ORTOS_DGT_1995' is not unique - used by 'Orthophotos of mainland Portugal - 1m - 1995 - Fake Color (DGT)' and 'Orthophotos of mainland Portugal - 1m - 1995 - Fake Color (DGT)'!
- 02098.168 W: Unable to convert property left-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02098.168 W: Unable to convert property right-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02098.169 W: Unable to convert property left-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02098.169 W: Unable to convert property right-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02119.175 W: Unable to convert property left-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02119.175 W: Unable to convert property right-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02119.238 W: Unable to convert property left-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!
- 02119.238 W: Unable to convert property right-casing-offset to type class java.lang.Float: found RelativeFloat{val=4.0} of type class org.openstreetmap.josm.gui.mappaint.mapcss.Instruction$RelativeFloat!

Attachments (1)

josm_layer_panel_help.png (76.8 KB ) - added by stoffld 2 years ago.

Download all attachments as: .zip

Change History (8)

by stoffld, 2 years ago

Attachment: josm_layer_panel_help.png added

comment:1 by Klumbumbus, 2 years ago

Resolution: fixed
Status: newclosed

In 18573/josm:

fix #22445 - Resize wikimedia_commons.svg image to base size of 16 px, which also slightly improves the display in the mapview (although this icon is not used in the mapview in core)

comment:2 by Klumbumbus, 2 years ago

This is actually a workaround for #15864.

comment:3 by Klumbumbus, 2 years ago

Milestone: 22.10
Type: enhancementdefect

comment:4 by taylor.smock, 2 years ago

comment:5 by Klumbumbus, 2 years ago

In 18577/josm:

see #22445 - fix icon viewbox

in reply to:  4 comment:6 by Klumbumbus, 2 years ago

Replying to taylor.smock:

@Klumbumbus: Did you intend 16.000002 to be 16?

No Yes, some problem with inkscape and I didn't double check the svg code before the commit.

Last edited 2 years ago by Klumbumbus (previous) (diff)

comment:7 by taylor.smock, 2 years ago

Fair enough. I figured I'd check since maybe there was some bug we were working around with 16.000002 (comment:2, "[this] is actually a workaround for #15864.")

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.