Change set source lists all backgrounds viewed from launch of JOSM

[SekeRob]

What steps will reproduce the problem?

When saving the changes, the source(s) listed afterwards include all background images that were viewed from the moment JOSM was launched. I'd like to see only those background -sat imageries- with which actual nodes/ways were added/changed, not viewed. A source list shown after a 4 hour, multi -non-split- save session.

Esri World Imagery; Esri World Imagery (Clarity) Beta; PCN 2006 - Italy; PCN 2012 - Italy; OpenStreetMap (Basque Style); OpenStreetMap (Breton Style); OpenStreetMap (Occitan Style); OpenStreetMap Carto (Standard)

Yes, we can change the source, but then why would the various map render formats be included? At the very least, the source list should be cleared/reset after the edit buffer has cleared.

MGIA

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-09-29 20:51:54 +0200 (Thu, 29 Sep 2022)
Revision:18565
Build-Date:2022-09-30 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18565 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 2060 MB / 4084 MB (503 MB allocated, but free)
Java version: 11.0.15+10-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop]
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36011)
+ pt_assistant (1ff2e15)
+ reltoolbox (35976)
+ reverter (36011)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 47811.716 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_06.map&LAYERS=OI.ORTOIMMAGINI.2006.33,OI.ORTOIMMAGINI.2006.32&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1568182.0722987,5176621.3035853,1568487.8204118,5176927.0516984&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 47815.025 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_06.map&LAYERS=OI.ORTOIMMAGINI.2006.33,OI.ORTOIMMAGINI.2006.32&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1567876.3241855,5174481.0667933,1569099.3166381,5175704.0592458&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 47815.214 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_06.map&LAYERS=OI.ORTOIMMAGINI.2006.33,OI.ORTOIMMAGINI.2006.32&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1567876.3241855,5175704.0592458,1569099.3166381,5176927.0516984&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 47818.581 W: java.net.SocketTimeoutException: connect timed out
- 47826.719 W: java.net.SocketTimeoutException: connect timed out
- 47830.223 W: java.net.SocketTimeoutException: connect timed out
- 47833.593 W: java.net.SocketTimeoutException: connect timed out
- 47837.435 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_12.map&LAYERS=OI.ORTOIMMAGINI.2012.32,OI.ORTOIMMAGINI.2012.33&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1565430.3392804,5174481.0667933,1566653.3317330,5175704.0592458&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 47854.343 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_12.map&LAYERS=OI.ORTOIMMAGINI.2012.32,OI.ORTOIMMAGINI.2012.33&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1570322.3090907,5176927.0516984,1571545.3015432,5178150.0441510&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 47854.750 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_06.map&LAYERS=OI.ORTOIMMAGINI.2006.33,OI.ORTOIMMAGINI.2006.32&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1569099.3166381,5174481.0667933,1570322.3090907,5175704.0592458&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap

[taylor.smock]

1. Did you still have all those layers available and non-hidden on upload?
2. It is rather difficult to track which changes go with which layers. Example: User enables imagery bar sees that a building has a flat roof, switches to imagery foo and then edits the building to have a flat roof. Which imagery layer should be associated with the edit? I'd argue that the one where the user saw the flat roof, but pretty much all automatic tracking will get this wrong. It might be right for 90%+ of the cases, which will just lead to false confidence for the remaining 10%.

[anonymous]

? Never knew one could hide layers and why would I, but noticed that memory usage absolutely explodes and is not being released leading to 4GB and more RAM use which is when things start to slow down, only known option exit JOSM and twiddle my thumbs while reloading the app, selected working background and data area load I was wortking on before. No release even when purging all of the data loaded from OSM with uptimes of the app from morning to night.

Don't know nothing about tracking, but being a convertee from 35K CS's in ID, the only record of sources on save and exit is if a node was changed/added in whichever active background when I make it my business to only map in ESRI, consult other backgrounds only if ESRI has poor or not visible parts (clouds). (ESRI Clarity on top is years if not a decade behind reality and badly offset, surely Italy 2006, 2012 only visited to see 'how it was').

Of course, why list the breton, occidental, standard OSM. They're to me only there for viewing pleasure, how mapping comes out as end product.

Anyway, that leaves me changing the source selection in the save panel, if I don't forget. Right now that recitation of imagery I viewed from dawn to dusk is as meaningless as can be. Says 0% about what true sources I've mapped in.

[GerdP]

I just wonder why e.g. OpenStreetMap (Basque Style) appears as source. Is that intended?

[taylor.smock]

Replying to GerdP:

I just wonder why e.g. OpenStreetMap (Basque Style) appears as source. Is that intended?

Not directly. It is largely just due to not filtering based off of layer name for the imagery layers. We can technically do that (i.e., if (imageryInfo.getUrl().startsWith("https://tile.openstreetmap.org"))), but we would need to put together a list of sources that shouldn't be added.

[GerdP]

There must already be some useful code that does the grouping in the menu

[taylor.smock]

Replying to GerdP:

There must already be some useful code that does the grouping in the menu

We can try using osmbasedmap.

[anonymous]

For the time being and on closer inspection of the save panel interface, I've unticked the "automatically..." box. I've flip flopped thru all the sat imageries and hit save, now only the Esri world imagery shows up in the data source box from the previous edit set manual selection. Think we can all agree that the automatic should exclude the rendered 'product' backgrounds.

[taylor.smock]

Replying to taylor.smock:

We can try using osmbasedmap.

Doesn't look like it -- there exists at least one map based off of osm that contains additional (topographic) data.