Opened 2 years ago
Last modified 2 years ago
#22412 new enhancement
Complain about end_date in the past
Reported by: | mkoniecz | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | template_report end_date | Cc: |
Description
end_date
may have rarely useful form in OSM: where it is known when something will become defunct
but ned_date
in past always indicates at least one of following
- some object is defunct and should be removed
end_date
tag is wrong (object was not removed)end_date
is not verifiable by survey and not useful as metadata (fordemolished:building=yes
that was temporarily kept as remains visible on aerial images, but all its properties can be removed)
What steps will reproduce the problem?
- Create
historic=memorial end_date=2021-09-30
node orhistoric=residential end_date=2021
way - Run validator
What is the expected result?
Validator complains about end_date
What happens instead?
Nothing
Please provide any additional information below. Attach a screenshot if possible.
Triggered by https://www.openstreetmap.org/node/8916967417/history - this wrong info had chance for staying for shorter time but it was sadly not detected by validator that it is wrong (maybe it would help)
See https://taginfo.openstreetmap.org/keys/end_date#values - note that many are not using full date format but for example just year.
Disclaimer: i have not investigated thoroughly actual instances of end_date
objects, Overpass reports that I overused it today.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2022-09-18 18:03:33 +0200 (Sun, 18 Sep 2022) Revision:18559 Build-Date:2022-09-19 01:30:56 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18559 en) Linux Ubuntu 20.04.5 LTS Memory Usage: 536 MB / 3974 MB (255 MB allocated, but free) Java version: 11.0.16+8-post-Ubuntu-0ubuntu120.04, Ubuntu, OpenJDK 64-Bit Server VM Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00) Maximum Screen Size: 1920×1200 Best cursor sizes: 16×16→16×16, 32×32→32×32 Environment variable LANG: en_US.UTF-8 System property file.encoding: UTF-8 System property sun.jnu.encoding: UTF-8 Locale info: en_US Numbers with default locale: 1234567890 -> 1234567890 Desktop environment: LXQt Java package: openjdk-11-jre:amd64-11.0.16+8-0ubuntu1~20.04 Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1 libcommons-logging-java: libcommons-logging-java:all-1.2-2 fonts-noto: fonts-noto:- Dataset consistency test: No problems found Plugins: + buildings_tools (36011) + measurement (35978) + reverter (36011) + todo (30306) Map paint styles: + ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss Validator rules: + https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1 - ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss + ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss Last errors/warnings: - 00018.770 W: Failed to load Mappaint styles from '${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss'. Exception was: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss - 00018.772 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss - 00018.782 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard - 00018.785 W: Initializing map style ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss completed in 14 ms (1 errors, 0 warnings) - 00036.263 W: Failed to add ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss to tag checker - 00036.264 W: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss
There is no problem with
end_date
in the past in general but it should not be used together with a primary tag. I often use it together withrazed:*
,removed:*
orremoved:*
as long as the feature is still visible on one of the available backgrounds.Maybe, an informal warning might work without taking the other tags into account.
Additionally, there is no option for mapcss to get the current date and calculate timespans, see #21429.