[Patch] Preview object properties on mouse hover

[Woazboat]

Show tags and relation memberships of an object in the properties dialog when moving the mouser pointer over it (similar to iD).

Can be enabled/disabled via settings (enabled by default)

​https://github.com/JOSM/josm/pull/104
​https://github.com/JOSM/josm/pull/104.patch

[taylor.smock]

In 18574/josm:

Fix #22378: Preview object properties on mouse hover (patch by Woazboat, modified)

Show tags and relation memberships of an object in the properties dialog when
moving the mouser pointer over it (similar to iD).

Can be enabled/disabled via settings (enabled by default)

[Patrik_B]

Hey guys, thank you for keep adding new features into JOSM. I am personally not a fan of this one, how can I disable it please? :)
I tried to change "propertiesdialog.preview-on-hover" and "propertiesdialog.preview-on-hover.always-show-selected" as "false" but didn't worked.

Thank you

[taylor.smock]

Replying to Patrik_B:

Hey guys, thank you for keep adding new features into JOSM. I am personally not a fan of this one, how can I disable it please? :)
I tried to change "propertiesdialog.preview-on-hover" and "propertiesdialog.preview-on-hover.always-show-selected" as "false" but didn't worked.

Thank you

Can you try via JOSM Preferences -> Display -> toggle Preview object properties on mouse hover? It is working for me.

[Patrik_B]

Yes that worked! Thank you very much :) sorry I didn't checked that setting myself

[skyper]

Well propertiesdialog.preview-on-hover is the correct advanced preference. I have updated the wiki (diff).

[Patrik_B]

The disabling doesn't work properly for me. Every time I restart JOSM or just delete all layers and then download OSM data it is showing the preview even tho I have the option unchecked in Display settings and also in Advanced Preferences "propertiesdialog.preview-on-hover" is set to false.

I have to "turn on" the feature in Preferences, close preferences and then turn it off in Preferences to disable it, every time I restart JOSM.

I recorded my screen how to replicate the issue ​https://sendspark.com/share/bl90oab1vxs80e91

[Woazboat]

Hmmm, I'll look into it but I'm away from home at the moment so it could take a couple of days.

[Woazboat]

I actually just had a bit of time to take a look at it. Turns out the layer visibility change listeners I had to add to fix ​this are missing a check and ended up effectively re-enabling the hover preview on layer (visibility) change.

​https://github.com/JOSM/josm/pull/105

[Woazboat]

New ticket for the bug: https://josm.openstreetmap.de/ticket/22487

[skyper]

Ticket #21371 has been marked as a duplicate of this ticket.

[anonymous]

It would be fantastic to have the same thing when hovering the objects list in the upload window to do a (quick) verify of tagging completeness before committing to the server or to just a check on added/changed objects in the current open change set.

[GerdP]

I find this behaviour very confusing. I am used to see the properties of the selected element. I really think the "hover over" should only do it's thing when nothing is selected.

[skyper]

Replying to GerdP:

I find this behaviour very confusing. I am used to see the properties of the selected element. I really think the "hover over" should only do it's thing when nothing is selected.

Please, take a look at advanced preference propertiesdialog.preview-on-hover.always-show-selected to disable it with selected objects.
I would say this should be set to false per default.

[GerdP]

Thanks for the hint.

I would say this should be set to false per default.

Depends on what false mean. I have to try.

[GerdP]

Just tried with r18612 and it seems changing the setting doesn't have an effect unless I create a new layer.
Besides that the defaults seem to work as I want them:

propertiesdialog.preview-on-hover	true
propertiesdialog.preview-on-hover.always-show-selected	true

[Woazboat]

Replying to GerdP:

I find this behaviour very confusing. I am used to see the properties of the selected element. I really think the "hover over" should only do it's thing when nothing is selected.

That should already be the default behavior. Did you change any of the settings?

https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java?rev=18574#L269

[GerdP]

Sorry, I am not sure what version and settings I used when I wrote comment:7. I disabled the hover over function and my preferences have both values set to false. I'll set both values to true again and see if I can reproduce my problem with latest.

[skyper]

Replying to GerdP:

Thanks for the hint.

I would say this should be set to false per default.

Depends on what false mean. I have to try.

Oh no, I mixed it up. true is correct as default, e.g. show on hover is disabled with selection.

Replying to GerdP:

Just tried with r18612 and it seems changing the setting doesn't have an effect unless I create a new layer.

Yes, same for me, the behavior is only changed with new layers.

[Woazboat]

Replying to skyper:

Replying to GerdP:

Just tried with r18612 and it seems changing the setting doesn't have an effect unless I create a new layer.

Yes, same for me, the behavior is only changed with new layers.

I can't reproduce the incorrect behavior you're seeing. It works as expected for me without changing to a new layer (r18612)

[GerdP]

I can reproduce like this:
1) select an object and hover
2) change option without changing the selection
3) hover again and nothing changes in the behaviour

You change the selection and I guess that's the difference?

[skyper]

Yes, selected objects seems to be the problem

1. start with fresh, empty preferences
2. download some data
3. select a object
4. change propertiesdialog.preview-on-hover.always-show-selected to false

Now the feature does not work at all.

Changing the preference without selection works as expected.

[Woazboat]

Replying to skyper:

Yes, selected objects seems to be the problem

1. start with fresh, empty preferences
2. download some data
3. select a object
4. change propertiesdialog.preview-on-hover.always-show-selected to false

Now the feature does not work at all.

Changing the preference without selection works as expected.

Fixed in ​https://github.com/JOSM/josm/pull/107

[taylor.smock]

In 18631/josm:

See #22378: Fix hover preview setting changes not being applied immediately (patch by Woazboat)