[PATCH] Make window for attached GPX waypoint images resizable

[stoffld]

What steps will reproduce the problem?

1. Open a GPX track that has images attached to waypoints
2. Click one of the waypoints on the map
3. It opens another window to view the image

Here's an example of such a waypoint:

  <wpt lat="49.697181" lon="12.1512866">
    <time>2022-08-30T16:11:14Z</time>
    <name>0JTMdAcL--.1.jpg</name>
    <link href="0JTMdAcL--.1.jpg" />
    <extensions />
  </wpt>

What is the expected result?

The window should be resizable.

What happens instead?

The image is scaled down to fit into a small window with a fixed size.

The problem gets even worse when the button to show the image in original size is clicked. Then the big image can only be viewed through the same small viewport and has to be scrolled with the scrollbars until finally the desired section is found.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-08-29 16:59:00 +0200 (Mon, 29 Aug 2022)
Revision:18543
Build-Date:2022-08-30 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18543 de) Linux Mint 21
Memory Usage: 376 MB / 3916 MB (160 MB allocated, but free)
Java version: 11.0.16+8-post-Ubuntu-0ubuntu122.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: de_DE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: X-Cinnamon
Java package: openjdk-11-jre:amd64-11.0.16+8-0ubuntu1~22.04
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20201225-1build1
VM arguments: [--module-path=/usr/share/openjfx/lib, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, -Djosm.restart=true, -Djava.net.useSystemProxies=true, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]

Plugins:
+ ImproveWay (32)
+ OpeningHoursEditor (35924)
+ PicLayer (1.0.2)
+ buildings_tools (36011)
+ changeset-viewer (v0.0.4)
+ contourmerge (v0.1.9)
+ imagery_offset_db (35978)
+ measurement (35978)
+ reltoolbox (35976)
+ utilsplugin2 (36011)

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Last errors/warnings:
- 00001.614 W: Erweiterungen aktualisieren - Sie haben JOSM aktualisiert. Zur Vermeidung von Problemen sollten die Erweiterungen ebenfalls aktualisiert werden.  Erweiterungen jetzt aktualisieren?

[stoffld]

Image window after button was clicked

[stoffld]

Image window in default view

[taylor.smock]

This should be using the ImageViewer instead of whatever it is using. I'll see if I can reproduce.

[taylor.smock]

Initial patch (no tests). Makes ImageMarker use the maintained image viewer, adds some interfaces to make it easier to read and apply exif data to orthogonal classes, move ImageViewerDialog creation and addition to map frame from GeoImageLayer to ImageViewerDialog#getInstance, add default read method in IImageEntry

[taylor.smock]

@stoffld: I've never used GPX waypoints for images before this patch. In my testing, everything worked, but I would appreciate it if you could check and make certain that it fixes your problem.

[stoffld]

@taylor.smock Great, thank you. I will have to wait for the next package update, though. I don't know how the release process for JOSM on Ubuntu/Debian works. Usually they release an update every 1-2 months I think but the last update was only some days ago.

Will report back here after the next update.

[stoffld]

@taylor.smock I missed the attachment above. I tried the patched jar and it seems to works fine.

[taylor.smock]

Thanks for letting me know that you had missed the attachment. I was in the process of writing a how to in order for me to know whether or not it worked as expected.

There are a few rough edges I need to fix in the patch (specifically, I need to add some tests), but I'll try to apply the patch Monday (I am currently in "major bug fix only mode" since I did a release on Tuesday).

EDIT: I've removed the jar file to save server space.

[stoffld]

It's probably not related to your fix but I thought I let you know anyway:

The patched version above has an issue with the display of downloaded areas. Usually unknown areas rendered hatched (I hope that's the right word for that pattern of diagonal lines).When you download an area, that pattern get removed.

This only works for the first download. When I download a second area, the data is rendered but the hatching pattern is still rendered over the new area.

[taylor.smock]

The fun part about working with SVN is that it doesn't really have branches.

I've been working on #7489 which comes with a rework of the dataset merging code (which is used by the download code).

Thanks for bringing that up.

[taylor.smock]

Note: I'm going to add a dependency on #21605 (tabbed image viewer).

[anonymous]

While I appreciate your work on #21605 and understand the connection I'm worried that this ticket gets postponed again and again as the other ticket is probably a bit more complicated to fix.

Would it maybe be possible to get a temporary quick & dirty fix in the next release, like simply unlocking the resize feature of the image window?

[taylor.smock]

The patch for this ticket is large enough that I don't want to apply it during release week. We are scheduled to make a release on Saturday October 29th (which probably means I'll be doing the release Monday October 31st).

Rather unfortunately, josm-latest isn't widely used, which means that it is less likely for breaking bugs to be reported. For those using josm-latest, I want there to be a fair amount of time for them to find bugs before it makes it into josm-tested. So I try to do larger patches at the start of each cycle (so I'll probably merge this and #21605 November 4th or 5th, assuming there are no breaking bugs in josm-tested).

[taylor.smock]

In 18592/josm:

Fix #22337: Make window for attached GPX waypoint images resizable

The GPX waypoint images used completely different code paths for
showing images. With this change, the GPX waypoint images are
viewed in ImageViewerDialog, along with GeoTagged Images.

[skyper]

Replying to stoffld:

I will have to wait for the next package update, though. I don't know how the release process for JOSM on Ubuntu/Debian works. Usually they release an update every 1-2 months.

Yes, the distributions usually only include a package of the tested release which is released once per month. You might want to have a look at our own ubuntu packages. Especially, josm-latest might be interesting as it is general quite stable. It can be installed in parallel to a tested version and is released once per day.

[taylor.smock]

In 18593/josm:

See #22337: Make window for attached GPX waypoint images resizable

This fixes broken tests.

[taylor.smock]

Milestone renamed